Bug 426643
| Summary: | Review Request: perl-Linux-Pid - Get the native PID and the PPID on Linux | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Xavier Bachelot <xavier> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-01-13 17:48:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Xavier Bachelot
2007-12-23 16:10:14 UTC
new version, fix missing BR : http://washington.kelkoo.net/fedora/SPECS/perl-Linux-Pid.spec http://washington.kelkoo.net/fedora/SRPMS/perl-Linux-Pid-0.04-2.fc8.src.rpm make test should execute all tests successfully
But here I see that
t/threaded....ok
2/9 skipped: thread model is NPTL 2.7.90
All tests successful, 2 subtests skipped.
I believe this is regular behavior. The tests are skipped, not failed. I think only Author/Developer tests that are skipped are ok. But all tests should be executed successfully. Not sure what you call 'Author/Developer tests'. Anyway, I'm asking some perl devs here to take a look at the issue. This test is OK. It is checking the runtime environment for a specific pthread model and skips some subtests if it doesn't find the pthread model this it wants to test the behavior of. What is not OK with this package's spec (MUSTFIX): 1. %check ||: We want to see breakdowns in testsuites => remove the ||: 2. the "BuildRequires:" BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(Test::More) seems sufficient. All others seem superfluous to me. thanks Ralf. Xavier, Can you please provide new updates SRPM that fix issues in above comment? Fixed in : http://washington.kelkoo.net/fedora/SPECS/perl-Linux-Pid.spec http://washington.kelkoo.net/fedora/SRPMS/perl-Linux-Pid-0.04-3.fc8.src.rpm Review:
+ package builds in mock (rawhide i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
130c4d299f827abf1f2285fddf03fccb Linux-Pid-0.04.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/basic.......ok
t/import......ok
t/threaded....ok
2/9 skipped: thread model is NPTL 2.7.90
All tests successful, 2 subtests skipped.
Files=3, Tests=13, 0 wallclock secs ( 0.08 cusr + 0.03 csys = 0.11 CPU)
+ Package perl-Linux-Pid-0.04-3.fc9 =>
Provides: Pid.so perl(Linux::Pid) = 0.04
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3)
perl(:MODULE_COMPAT_5.8.8) perl(XSLoader) perl(strict) perl(warnings)
APPROVED.
Thx Parag. New Package CVS Request ======================= Package Name: perl-Linux-Pid Short Description: Get the native PID and the PPID on Linux Owners: xavierb Branches: F-8 InitialCC: Cvsextras Commits: yes cvs done. Imported and built for devel and F-8. |