Bug 426728

Summary: Review Request: glpi-data-injection - Plugin for importing data into GLPI
Product: [Fedora] Fedora Reporter: Remi Collet <fedora>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, kevin, notting
Target Milestone: ---Flags: fedora: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-01-29 05:27:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Comment 2 Johan Cwiklinski 2008-01-26 11:40:44 UTC
Review:
+ package builds in mock.
+ rpmlint is silent for SRPM and RPMs.
+ source file are ok.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ BuildRequires are proper.
+ package installed properly.
+ Macro use appears rather consistent.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.

APPROVED.

Comment 3 Remi Collet 2008-01-26 16:01:00 UTC
New Package CVS Request
=======================
Package Name: glpi-data-injection
Short Description: Plugin for importing data into GLPI
Owners: remi
Branches: F-7 F-8 EL-4 EL-5
InitialCC: 
Cvsextras Commits: yes


Comment 4 Kevin Fenzi 2008-01-26 18:01:24 UTC
Johan: Can you please set the fedora-review flag to + if you approve this package?


Comment 5 Johan Cwiklinski 2008-01-26 18:17:16 UTC
Sorry, i've forgot :/ Flag is no set.

Comment 6 Kevin Fenzi 2008-01-27 19:21:06 UTC
cvs done.