Bug 426738
Summary: | Review Request: pards - A library for PARallel programs with Dataflow Synchronization | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | MASA.H <masahase> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, mtasaka, notting |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-01-14 02:52:38 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
MASA.H
2007-12-25 17:21:58 UTC
_Very_ quick check (before I can sponsor you). I am just glancing at your spec file. - Please fix SourceURL ref: http://cvs.fedoraproject.org/viewcvs/*checkout*/devel/jd/jd.spec - BuildRequires: glibc-common, binutils are redundant - Usually -devel package should have the dependency for main package (please see the line "MUST: In the vast majority of cases, devel packages must... of http://fedoraproject.org/wiki/Packaging/ReviewGuidelines ) - "Group" of main package perhaps needs fixing ref: http://cvs.fedoraproject.org/viewcvs/*checkout*/devel/libtcd/libtcd.spec - Move char code conversion section from %build to %prep (for rpmbuild -bc --short-circuit) - Use "-p" option when using "cp" or "install" commands ("Timestamps" section of Guildlines wiki) - Remove static archives unless needed - It seems that -devel package does not contain any symlinks against installed libraries?? (by the way "make install ...." does not work?) - Stripping binaries by yourself is forbidden. ! Please insert one line between --------------------------------------------------------- %doc ChangeLog README README.ja LICENSE %files devel ---------------------------------------------------------- Ooops! fixed; Spec URL: http://www.masahase.mydns.jp/SRPMS/pards.spec SRPM URL: http://www.masahase.mydns.jp/SRPMS/pards-0.4-2.fc7.src.rpm Well, - http://downloads.sourceforge.jp/pards/pards04.tar.gz returns 404 (not found). - Rebuild fails on 64 bits arch (installation failure) http://koji.fedoraproject.org/koji/taskinfo?taskID=310050 One more issue: --------------------------------------------------------------------- [root@localhost ~]# rpmlint pards pards.i386: W: undefined-non-weak-symbol /usr/lib/libpards.so.0.4 _ZTVN10__cxxabiv120__si_class_type_infoE pards.i386: W: undefined-non-weak-symbol /usr/lib/libpards.so.0.4 _ZTVN10__cxxabiv117__class_type_infoE pards.i386: W: undefined-non-weak-symbol /usr/lib/libpards.so.0.4 __gxx_personality_v0 pards.i386: W: undefined-non-weak-symbol /usr/lib/libpards.so.0.4 _ZdlPv pards.i386: W: undefined-non-weak-symbol /usr/lib/libpards.so.0.4 __cxa_allocate_exception pards.i386: W: undefined-non-weak-symbol /usr/lib/libpards.so.0.4 __cxa_throw pards.i386: W: undefined-non-weak-symbol /usr/lib/libpards.so.0.4 _Znwj ------------------------------------------------------------------------ This means that libpards.so contains undefined non-weak symbol. For packages providing -devel subpackage, this cannot be allowed because these symbols cause linkage failure against this library. Oh, shit. >404 I miss repoid in soreceURL. >fails on 64bit It mistakenly defined libdir as ${prefix}/lib on all enviroment in Makefile. But on 64bit it is ${prefix}/lib64. >undefined non-weak symbol. Oh, I missed "-lstdc++". BTW, I have a question. My rpmlint doesn't tell. To tell needs some options or new version? fixed; Spec URL: http://www.masahase.mydns.jp/SRPMS/pards.spec SRPM URL: http://www.masahase.mydns.jp/SRPMS/pards-0.4-3.fc7.src.rpm (In reply to comment #1) > - Remove static archives unless needed Umm.. It seems that originally this package does not provide any shared libraries but only a static archive. Then you try to apply a patch to provide a shared library with soname given by _you_. This is actually problematic because we cannot tell if ABI of the library really does not change when _upstream_ changes from 0.4 to 0.5, for example. c.f https://bugzilla.redhat.com/show_bug.cgi?id=211626#c15 (the whole discussion is very long) Well, now we allow to provide static archives when it is unavoidable. Would you check the section "Packaging Static Libraries" of http://fedoraproject.org/wiki/Packaging/Guidelines (especially the subsection "When a package only provides static libraries" ) and rewrite your srpm? BTW:
> >undefined non-weak symbol.
> Oh, I missed "-lstdc++".
> BTW, I have a question. My rpmlint doesn't tell. To tell needs some options or
> new version?
You can try rpmlint against installed rpms, too, for example:
$ rpmlint pards
>original provides only static library I see there's no assurance for ABI. I'm trying to contact upstream developer, and send my patch. I continue to wait his reply. As interim alternative I rewrite; Spec URL: http://www.masahase.mydns.jp/SRPMS/pards.spec SRPM URL: http://www.masahase.mydns.jp/SRPMS/pards-0.4-4.fc7.src.rpm Well, for now I will wait for upstream reply. Upstream promised to no change ABI during same major version. And my patch will merge next release. So I will revert the pakcage from 4.fc7 to 3.fc7. Is it O.K? Well, would you "increase" release number anyway and resubmit your newest srpm? Of course, I'll increase. But I am away from my console, so resubmiting will late. Okay. BTW a happy new year!! Happy new year! Sorry, too late. Spec URL: http://www.masahase.mydns.jp/SRPMS/pards.spec SRPM URL: http://www.masahase.mydns.jp/SRPMS/pards-0.4-5.fc7.src.rpm Well, this package is okay ---------------------------------------------------------- This package (pards) is APPROVED by me ---------------------------------------------------------- So would you contact with accounts as written in http://fedoraproject.org/wiki/Infrastructure/AccountSystem/Contact about GPG key problem if you still have the problem? I've send a mail to accounts, and recived mail from Mike McGrath <mmcgrath>. But it has not solved yet. How about create a new GPG key for now? Um... That is last way, I think. But I'll try it. I succeeded!! Thank you very much. Okay, now I am sponsoring you. Please proceed following "Join" wiki. New Package CVS Request ======================= Package Name: pards Short Description: A library for PARallel programs with Dataflow Synchronization Owners: masahase Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes cvs done. All builds succeeded. |