Bug 426830
| Summary: | Review Request: perl-XML-Xerces - Perl API to Xerces XML parser | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Xavier Bachelot <xavier> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-01-13 17:48:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Xavier Bachelot
2007-12-27 01:39:18 UTC
Preliminary review 1) Source URL is not working it should be http://www.apache.org/dist/xml/xerces-p/XML-Xerces-%{ver}-%{PatchLevel}.tar.gz 2) make test skipped some tests. All tests should be executed successfully. check http://koji.fedoraproject.org/koji/getfile?taskID=310773&name=build.log FWIW, in my local old package of this, I had: %check # See FAQ: non-"C" LC_CTYPE needed for tests. Actually, at least when # using a Xerces built with ICU, non-"C" LANG is needed. LANG=en_US make test IIRC this package is also very picky about the xerces-c-devel version, I had:
BuildRequires: xerces-c-devel = %{version}
Thanks Parag, I've fixed the URL. Thanks for your comments Ville. I've added the more strict BR on xerces-c-devel. Changing LANG doesn't change the tests results, though. I'm asking some perl devs here to look at the issues. New version : http://washington.kelkoo.net/fedora/SPECS/perl-XML-Xerces.spec http://washington.kelkoo.net/fedora/SRPMS/perl-XML-Xerces-2.7.0_0-3.fc8.src.rpm %check ||: is a no-go. Fixed in : http://washington.kelkoo.net/fedora/SPECS/perl-XML-Xerces.spec http://washington.kelkoo.net/fedora/SRPMS/perl-XML-Xerces-2.7.0_0-4.fc8.src.rpm Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url e5bd871026bee1b291c5634e6e4daf35 XML-Xerces-2.7.0-0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs All tests successful, 5 subtests skipped. Files=43, Tests=35542, 15 wallclock secs (11.82 cusr + 2.04 csys = 13.86 CPU) ==>Not sure about how to resolve skipped test. So I will approve this and if anyone feels these tests should not be skipped then once package gets inside CVS file bug against it. + Package perl-XML-Xerces-2.7.0_0-4.fc9 => Provides: Xerces.so perl(XML::Xerces) = 260.2 perl(XML::Xerces::AbstractDOMParser) perl(XML::Xerces::AttributeList) perl(XML::Xerces::Attributes) perl(XML::Xerces::ContentHandler) perl(XML::Xerces::DOMAttr) perl(XML::Xerces::DOMBuilder) perl(XML::Xerces::DOMCDATASection) perl(XML::Xerces::DOMCharacterData) perl(XML::Xerces::DOMComment) perl(XML::Xerces::DOMDocument) perl(XML::Xerces::DOMDocumentFragment) perl(XML::Xerces::DOMDocumentRange) perl(XML::Xerces::DOMDocumentTraversal) perl(XML::Xerces::DOMDocumentType) perl(XML::Xerces::DOMElement) perl(XML::Xerces::DOMEntity) perl(XML::Xerces::DOMEntityReference) perl(XML::Xerces::DOMEntityResolver) perl(XML::Xerces::DOMErrorHandler) perl(XML::Xerces::DOMException) perl(XML::Xerces::DOMImplementation) perl(XML::Xerces::DOMImplementationLS) perl(XML::Xerces::DOMImplementationRegistry) perl(XML::Xerces::DOMImplementationSource) perl(XML::Xerces::DOMInputSource) perl(XML::Xerces::DOMLocator) perl(XML::Xerces::DOMNamedNodeMap) perl(XML::Xerces::DOMNode) perl(XML::Xerces::DOMNodeFilter) perl(XML::Xerces::DOMNodeIterator) perl(XML::Xerces::DOMNodeList) perl(XML::Xerces::DOMNotation) perl(XML::Xerces::DOMProcessingInstruction) perl(XML::Xerces::DOMRange) perl(XML::Xerces::DOMRangeException) perl(XML::Xerces::DOMText) perl(XML::Xerces::DOMTreeWalker) perl(XML::Xerces::DOMWriter) perl(XML::Xerces::DOMWriterFilter) perl(XML::Xerces::DTDAttDef) perl(XML::Xerces::DTDAttDefList) perl(XML::Xerces::DTDElementDecl) perl(XML::Xerces::DTDElementDeclEnumerator) perl(XML::Xerces::DTDEntityDecl) perl(XML::Xerces::DTDEntityDeclEnumerator) perl(XML::Xerces::DTDGrammar) perl(XML::Xerces::DTDHandler) perl(XML::Xerces::DTDValidator) perl(XML::Xerces::DeclHandler) perl(XML::Xerces::DefaultHandler) perl(XML::Xerces::DocumentHandler) perl(XML::Xerces::EntityResolver) perl(XML::Xerces::ErrorHandler) perl(XML::Xerces::Grammar) perl(XML::Xerces::HandlerBase) perl(XML::Xerces::InputSource) perl(XML::Xerces::LexicalHandler) perl(XML::Xerces::LocalFileFormatTarget) perl(XML::Xerces::LocalFileInputSource) perl(XML::Xerces::Locator) perl(XML::Xerces::MemBufFormatTarget) perl(XML::Xerces::MemBufInputSource) perl(XML::Xerces::PSVIHandler) perl(XML::Xerces::Parser) perl(XML::Xerces::PerlCallbackHandler) perl(XML::Xerces::PerlContentCallbackHandler) perl(XML::Xerces::PerlContentHandler) perl(XML::Xerces::PerlDocumentCallbackHandler) perl(XML::Xerces::PerlDocumentHandler) perl(XML::Xerces::PerlEntityResolver) perl(XML::Xerces::PerlEntityResolverHandler) perl(XML::Xerces::PerlErrorCallbackHandler) perl(XML::Xerces::PerlErrorHandler) perl(XML::Xerces::PerlNodeFilter) perl(XML::Xerces::PerlNodeFilterCallbackHandler) perl(XML::Xerces::QName) perl(XML::Xerces::SAX2XMLReader) perl(XML::Xerces::SAXException) perl(XML::Xerces::SAXNotRecognizedException) perl(XML::Xerces::SAXNotSupportedException) perl(XML::Xerces::SAXParseException) perl(XML::Xerces::SAXParser) perl(XML::Xerces::SchemaAttDef) perl(XML::Xerces::SchemaAttDefList) perl(XML::Xerces::SchemaElementDecl) perl(XML::Xerces::SchemaElementDeclEnumerator) perl(XML::Xerces::SchemaGrammar) perl(XML::Xerces::SchemaValidator) perl(XML::Xerces::StdInInputSource) perl(XML::Xerces::StdOutFormatTarget) perl(XML::Xerces::URLInputSource) perl(XML::Xerces::Wrapper4DOMInputSource) perl(XML::Xerces::Wrapper4InputSource) perl(XML::Xerces::Writer) perl(XML::Xerces::XMLAttDef) perl(XML::Xerces::XMLAttDefList) perl(XML::Xerces::XMLCatalogResolver) perl(XML::Xerces::XMLDTDDescription) perl(XML::Xerces::XMLDeleter) perl(XML::Xerces::XMLElementDecl) perl(XML::Xerces::XMLEntityDecl) perl(XML::Xerces::XMLException) perl(XML::Xerces::XMLExcepts) perl(XML::Xerces::XMLGrammarDescription) perl(XML::Xerces::XMLNotationDecl) perl(XML::Xerces::XMLPScanToken) perl(XML::Xerces::XMLPlatformUtils) perl(XML::Xerces::XMLReaderFactory) perl(XML::Xerces::XMLSchemaDescription) perl(XML::Xerces::XMLSimple) perl(XML::Xerces::XMLURL) perl(XML::Xerces::XMLUni) perl(XML::Xerces::XMLUri) perl(XML::Xerces::XMLValidator) perl(XML::Xerces::XercesDOMParser) perl(XML::Xercesc) Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libpthread.so.0 libpthread.so.0(GLIBC_2.0) libxerces-c.so.27 perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(DynaLoader) perl(Exporter) perl(strict) perl(vars) rtld(GNU_HASH) APPROVED. Thx Parag. New Package CVS Request ======================= Package Name: perl-XML-Xerces Short Description: Perl API to Xerces XML parser Owners: xavierb Branches: F-8 InitialCC: Cvsextras Commits: yes cvs done. Imported and built for devel and F-8. |