Bug 427047

Summary: broken string handling in init script
Product: [Fedora] Fedora Reporter: Christian Krause <chkr>
Component: radvdAssignee: Martin Nagy <mnagy>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 8CC: hripps, pekkas
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 1.1-2.fc9 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-02-25 12:24:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch which fixes the string compare problem none

Description Christian Krause 2007-12-30 17:11:44 UTC
Description of problem:
calling the init script without any parameter results in the following error message

root@:~# /etc/init.d/radvd 
/etc/init.d/radvd: line 31: [: ==: unary operator expected
Usage: /etc/init.d/radvd {start|stop|status|restart|reload|condrestart}



Version-Release number of selected component (if applicable):
radvd-1.0-5.fc8


How reproducible:
100%


Additional info:
I've attached a very small patch for the init script which fixes the broken
string compare by using quotation marks like:

if [ "$1" = "status" ]; then 
...

Comment 1 Christian Krause 2007-12-30 17:11:44 UTC
Created attachment 290553 [details]
patch which fixes the string compare problem

Comment 2 Christian Krause 2008-02-14 22:18:14 UTC
I've checked current version of radvd in rawhide (radvd-1.0-6.fc9.i386) and the
problem is there as well.

Sure, the severity is low, but the patch is trivial and should not break
anything.  Please can it be applied? ;-)



Comment 3 Martin Nagy 2008-02-25 12:24:52 UTC
Thanks for reporting this.
Fixed in radvd-1.1-2.fc9

Comment 4 Pekka Savola 2008-02-27 13:08:05 UTC
Patch also added to upstream CVS, will be in the next release, whenever that is.