Bug 427218
| Summary: | Review Request: drpython - a python IDE channel | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marc Wiriadisastra <marc> |
| Component: | Package Review | Assignee: | Mads Villadsen <maxx> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | maxx:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-01-06 01:40:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Marc Wiriadisastra
2008-01-02 11:10:20 UTC
builds cleanly in mock (fedora-8-i386) rpmlint output: drpython.noarch: W: file-not-utf8 /usr/share/doc/drpython-165/History.txt drpython.noarch: W: file-not-utf8 /usr/share/doc/drpython-165/Changelog.txt drpython.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 11) The utf-8 issues need not be fixed - but please fix the mixed spaces and tabs in the .spec file. The Icon entry in the .desktop should be without the file extension (ie. drpython instead of drpython.png). It might be nice to include a small shell script called drpython which could be installed in /usr/bin to start drpython. The icon drpython.png must be installed to /usr/share/pixmaps to be found by the .desktop file. So all in all it looks quite good. The issues that must be fixed are: 1) the mixed use of tabs and spaces in the .spec file 2) the icon must be installed so that it shows up in the menus And of course it would be nice if some of the other minor issues could be fixed as well. All fixed hopefully. I've cleaned up the spec file compared to the previous one using a for loop. I have renamed the patch as well mainly for clarity on my sake for my sources directory. http://mwiriadi.fedorapeople.org/packages/drpython/drpython-165-2.fc8.src.rpm http://mwiriadi.fedorapeople.org/packages/drpython/drpython.spec http://mwiriadi.fedorapeople.org/packages/drpython/drpython-setup.py.postinst.patch http://mwiriadi.fedorapeople.org/packages/drpython/drpython.desktop http://mwiriadi.fedorapeople.org/packages/drpython/drpython.sh This looks very nice now. You still have to fix the mixed use of tabs and spaces in the .spec file - it is the last thing keeping rpmlint from being quiet. Fix that and I will approve this package. Sorry updated it http://mwiriadi.fedorapeople.org/packages/drpython/drpython.spec http://mwiriadi.fedorapeople.org/packages/drpython/drpython-165-3.fc8.src.rpm This looks fine. Accepted. New Package CVS Request ======================= Package Name: drpython Short Description: DrPython is a highly customizable cross-platform ide Owners: mwiriadi Branches: F-8 devel InitialCC: mwiriadi Cvsextras Commits: yes CVS Done Package Change Request ====================== Package Name: drpython New Branches: FC-7 CVS Done |