Bug 427226

will review this.

Just want to know why this patch is needed bless-0.5.2-buildfix.patch ?

rpmlint is not happy with messages
bless.src:41: E: hardcoded-library-path in %{_prefix}/lib
bless.src:66: E: hardcoded-library-path in %{_prefix}/lib/bless/

other rpmlint message is ok as per mono packaging guidelines.
bless.noarch: E: only-non-binary-in-usr-lib

use scrollkeeper scriptlet as given at
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

(In reply to comment #2)
> Just want to know why this patch is needed bless-0.5.2-buildfix.patch ?

Because the data in the po directory breaks the build and there aren't any
translations included anyway (in the tarball).

> rpmlint is not happy with messages
> bless.src:41: E: hardcoded-library-path in %{_prefix}/lib
> bless.src:66: E: hardcoded-library-path in %{_prefix}/lib/bless/

I know but I had to do this because using libdir would result in either
/usr/lib64/ or /usr/lib/ depending on the build host. And since this is a noarch
package it has to use /usr/lib.

> other rpmlint message is ok as per mono packaging guidelines.
> bless.noarch: E: only-non-binary-in-usr-lib

ok.

(In reply to comment #3)
> use scrollkeeper scriptlet as given at
> http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

Fixed:
http://tgmweb.at/gadllah/bless.spec
http://tgmweb.at/gadllah/bless-0.5.2-2.fc8.src.rpm

"We use %{_libdir} because we do not consider mono packages to be noarch." 
So I changed it to not be noarch.

http://tgmweb.at/gadllah/bless.spec
http://tgmweb.at/gadllah/bless-0.5.2-3.fc8.src.rpm

I think you also need to add
ExclusiveArch: %ix86 x86_64 ppc ia64 armv4l sparc alpha
as BR's of this package includes them.
Build failed on koji
http://koji.fedoraproject.org/koji/getfile?taskID=323749&name=root.log

Added: 
http://tgmweb.at/gadllah/bless.spec
http://tgmweb.at/gadllah/bless-0.5.2-4.fc8.src.rpm

SHOULD:
  follow use scrollkeeper scriptlet as given at
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets with proper post and
postun requires.
   As per given on http://fedoraproject.org/wiki/Packaging/Mono
We use %{_libdir} because we do not consider mono packages to be noarch. 
 Follow mono packaging guidelines.

(In reply to comment #9)
> SHOULD:
>   follow use scrollkeeper scriptlet as given at
> http://fedoraproject.org/wiki/Packaging/ScriptletSnippets with proper post and
> postun requires.

Fixed.

>    As per given on http://fedoraproject.org/wiki/Packaging/Mono
> We use %{_libdir} because we do not consider mono packages to be noarch. 
>  Follow mono packaging guidelines.

Already fixed this see comment 6 ;)

New SPEC and SRPM:
http://tgmweb.at/gadllah/bless.spec
http://tgmweb.at/gadllah/bless-0.5.2-5.fc8.src.rpm

Review:
+ package builds in mock (rawhide i386).
- rpmlint is NOT silent for RPM But Silent for SRPM.
bless.i386: E: only-non-binary-in-usr-lib
bless.i386: E: no-binary
==> This is ok as per mono packaging guidelines.
+ source files match upstream.
2f395e0b0c82382c49864947aea894ca  bless-0.5.2.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present in separate -doc subpackage.
+ BuildRequires are proper.
+ Compiler flags are honored correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Desktop files handled correctly.
+ scrollkeeper scriptlets are used.
+GUI app.

APPROVED.

(In reply to comment #11)
>
> APPROVED.
>

thx for the review.

================ 

New Package CVS Request
=======================
Package Name: bless
Short Description: High quality, full featured hex editor
Owners: drago01
Branches: F-7 F-8
Cvsextras Commits: yes

cvs done.