Bug 427300
Summary: | Review Request: python-kerberos - A high-level wrapper for Kerberos (GSSAPI) operations | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Rob Crittenden <rcritten> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
dennis: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-01-12 15:13:25 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Rob Crittenden
2008-01-02 21:08:01 UTC
package is missing BuildRequires: krb5-devel when tried to build manually from tarball using python setup.py build I got errors and then I need to replace src/*.c #include <Python/Python.h> to #include <Python.h> and build got successful. oops. I see that you are not member of cvsextras group. In that case you need apply and seek someone to sponsor you for cvsextras group. are you need Sponsor? Sorry for above comment. I missed to see your name in database. You are already there. Added krb5-devel to BuildRequires, thanks. Spec URL: http://rcritten.fedorapeople.org/python-kerberos.spec SRPM URL: http://rcritten.fedorapeople.org/python-kerberos-1.0-2.fc7.src.rpm Per comment #2 there is a patch included in the src.rpm to fix that: PyKerberos-includes.patch There's no need that I can see this package to follow "Providing Eggs for non-setuptools packages" If anyone want this package to provide egg-info then file a bug once this gets in Fedora. Review: Review: + package builds in mock (development i386). + rpmlint is silent for RPM But not for SRPM python-kerberos.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 19) ==> its cosmetic message. You can fix that using sed. + source files match upstream. e9bc790e51187f3afa13dc2611e5d93a python-kerberos-1.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Compiler flags are honored correctly. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Package python-kerberos-1.0-2.fc9 -> Provides: kerberos.so Requires: python(abi) = 2.5 + Not a GUI app. APPROVED. New Package CVS Request ======================= Package Name: python-kerberos Short Description: A high-level wrapper for Kerberos (GSSAPI) operations Owners: rcritten Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes CVS Done Closing this Review ticket as this package is successfully built on koji for requested branches. FYI: bug 429016 Thanks Ville, looks like I missed that. Package Change Request ====================== Package Name: python-kerberos New Branches: EL-5 Owners: rcritten CVS Done |