Bug 427480

[root@dhcp1-17 ~]# rpmlint perl-XML-TreeBuilder-3.10-2.fc9.src.rpm 
perl-XML-TreeBuilder.src:30: W: setup-not-quiet
perl-XML-TreeBuilder.src:33: W: rpm-buildroot-usage %build %{__perl} Makefile.PL
INSTALLDIRS="vendor" PREFIX="%{buildroot}%{_prefix}"
perl-XML-TreeBuilder.src: W: non-standard-group Applications/CPAN
perl-XML-TreeBuilder.src: W: invalid-license Artistic/GPL

Here is what would suit this better:

1. setup -q, but i guess this should be ok.

2. %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"

3. Group: I would rather choose: Development/Libraries

4. License: GPL+ or Artistic would be more appropriate.  
http://fedoraproject.org/wiki/Licensing

(In reply to comment #2)

All these changes have been made to the spec file.

> Here is what would suit this better:
> 
> 1. setup -q, but i guess this should be ok.
> 
> 2. %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
> 
> 3. Group: I would rather choose: Development/Libraries
> 
> 4. License: GPL+ or Artistic would be more appropriate.  
> http://fedoraproject.org/wiki/Licensing
> 
> 

4. What i meant is GPL+ "OR" Artistic not "GPL+ or Artistic"

Also have you rebuild the srpm with the new spec file.

Review for initial SRPM posted in comment 
1)Not needed following in SPEC
%define perl_vendorlib %(eval "`%{__perl} -V:installvendorlib`"; echo
$installvendorlib)
%define perl_vendorarch %(eval "`%{__perl} -V:installvendorarch`"; echo
$installvendorarch)

2) use simple way instead to use like this
%dir %{perl_vendorlib}/XML/
%{perl_vendorlib}/XML/Element.pm
%{perl_vendorlib}/XML/TreeBuilder.pm
use following
%{perl_vendorlib}/XML

3) License should be GPL+ or Artistic

4) use setup -q
 
5) remove META.yml, MANIFEST and MANIFEST.SKIP from %doc

6) make Group to Development/Libraries

7) missing BR and requires. Add following to SPEC
BuildRequires: perl(HTML::Element)
BuildRequires: perl(HTML::Tagset)
BuildRequires: perl(XML::Parser)
Requires: perl(HTML::Element) perl(HTML::Tagset) perl(XML::Parser)

8)%install should use following
%{__make} pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT


Always keep habit of updating SPEC and SRPM links with updateing release tag and
adding what changes you did in SPEC.

Provide updated SPEC and SRPM links.

http://svn.fedorahosted.org/svn/documentation-devel/trunk/Files/perl-XML-TreeBuilder.spec
http://svn.fedorahosted.org/svn/documentation-devel/trunk/Files/perl-XML-TreeBuilder-3.10-3.fc9.noarch.rpm

http://svn.fedorahosted.org/svn/documentation-devel/trunk/Files/perl-XML-TreeBuilder-3.10-3.fc9.src.rpm

1)Any reason for not following point 7 from comment #5?
build.log from mock build showed me
Warning: prerequisite HTML::Element 3.08 not found.
Warning: prerequisite HTML::Tagset 3.02 not found.
Warning: prerequisite XML::Parser 0 not found.

2)Wrong group Development/Languages

Again,
    Please provide updated SPEC and SRPM links fixing above issues.

http://svn.fedorahosted.org/svn/documentation-devel/trunk/Files/perl-XML-TreeBuilder-3.10-4.fc9.src.rpm
http://svn.fedorahosted.org/svn/documentation-devel/trunk/Files/perl-XML-TreeBuilder.spec

This package is ready for official review. But as you need sponsor, I can
sponsor and review this and other packages from you provided you also review few
other new packages waiting for review.

also, Change Source URL as provided URL in SPEC is not working. correct one is
http://search.cpan.org/CPAN/authors/id/S/SB/SBURKE/XML-TreeBuilder-%{version}.tar.gz

I see that you have not added 
%check
make test

Add above section. But when added "make test" failed. It should not fail and
should execute all tests successfully.
build.log gave me
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/00about....ok
t/10main.....# Failed test 2 in t/10main.t at line 33
#  t/10main.t line 33 is: ok $x->same_as($y);
FAILED test 2
        Failed 1/3 tests, 66.67% okay
Failed Test Stat Wstat Total Fail  Failed  List of Failed
-------------------------------------------------------------------------------
t/10main.t                 3    1  33.33%  2
Failed 1/2 test scripts, 50.00% okay. 1/6 subtests failed, 83.33% okay.
make: *** [test_dynamic] Error 255

* Fri Jan 11 2008 Jeff Fearn <jfearn> - 3.10-5
- Fixed test
- Fixed Source URL
- Added %%check

http://svn.fedorahosted.org/svn/documentation-devel/trunk/Files/perl-XML-TreeBuilder.spec
http://svn.fedorahosted.org/svn/documentation-devel/trunk/Files/perl-XML-TreeBuilder-3.10-5.fc9.src.rpm

It would be nice to shorten the summary to fit on a 80 char line.

(In reply to comment #15)
> It would be nice to shorten the summary to fit on a 80 char line.

Done.

http://svn.fedorahosted.org/svn/documentation-devel/trunk/Files/perl-XML-TreeBuilder.spec
http://svn.fedorahosted.org/svn/documentation-devel/trunk/Files/perl-XML-TreeBuilder-3.10-6.fc9.src.rpm

why source XML-TreeBuilder-3.10.tar.gz is not on CPAN?

(In reply to comment #17)
> why source XML-TreeBuilder-3.10.tar.gz is not on CPAN?

Simply a time issue, too many things to do so joining CPAN hasn't made the
action list yet. I hope to get to it after the production system has been upgraded.

Review:
+ package builds in mock (rawhide i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
943d0175044a1a4b1b419daa8dc8ddca  XML-TreeBuilder-3.10.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
t/00about....ok
t/10main.....ok
All tests successful.
Files=2, Tests=6,  1 wallclock secs ( 0.14 cusr +  0.03 csys =  0.17 CPU)
+ Package perl-XML-TreeBuilder-3.10-6.fc9 ->
  Provides: perl(XML::Element) = 3.09 perl(XML::TreeBuilder) = 3.10
  Requires: perl >= 1:5 perl(Carp) perl(HTML::Element) perl(HTML::Element) >=
3.08 perl(HTML::Tagset) perl(HTML::Tagset) perl(XML::Element) perl(XML::Parser)
perl(XML::Parser) perl(strict) perl(vars)

SHOULD:
     try to push new release on CPAN.

APPROVED.

I am really sorry here. I actually asked source tarball issue on #fedora-devel,
But I failed to put it in correct way. Now as Jason got the question what I want
to ask there and he already commented on this issues
https://bugzilla.redhat.com/show_bug.cgi?id=427479#c11, I prefer to take back
approved review.

Sorry Jfearn. If its not allowed in fedora then I was wrong in approving this
review.

Created attachment 292102 [details]
patch to upstream tarball

Please package perl-XML-TreeBuilder-3.09 with patch attached here and submit
new package for review.

oops I just took diff of upstream tarball and your tarball. please create new
patch and apply it in SPEC and submit new SRPM.

http://svn.fedorahosted.org/svn/documentation-devel/trunk/Files/perl-XML-TreeBuilder.spec
http://svn.fedorahosted.org/svn/documentation-devel/trunk/Files/perl-XML-TreeBuilder-3.09-8.fc9.src.rpm

This built successfully in koji.
But I don't think providing perl(XML::TreeBuilder) = 3.10 is valid as rpm
version is 3.09 it should provide => perl(XML::TreeBuilder) = 3.09

Missed one 3.10

http://svn.fedorahosted.org/svn/documentation-devel/trunk/Files/perl-XML-TreeBuilder.spec
http://svn.fedorahosted.org/svn/documentation-devel/trunk/Files/perl-XML-TreeBuilder-3.09-9.fc9.src.rpm

Review:
+ package builds in mock (rawhide i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
49e04fb6ba12b1414cb490e7f0c712a9  XML-TreeBuilder-3.09.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
t/00about....ok
t/10main.....ok
All tests successful.
Files=2, Tests=6,  0 wallclock secs ( 0.12 cusr +  0.01 csys =  0.13 CPU)
+ Package perl-XML-TreeBuilder-3.09-9.fc9 ->
  Provides: perl(XML::Element) = 3.09 perl(XML::TreeBuilder) = 3.09
  Requires: perl >= 1:5 perl(Carp) perl(HTML::Element) perl(HTML::Element) >=
3.08 perl(HTML::Tagset) perl(HTML::Tagset) perl(XML::Element) perl(XML::Parser)
perl(XML::Parser) perl(strict) perl(vars)
APPROVED.

New Package CVS Request
=======================
Package Name: perl-XML-TreeBuilder
Short Description: Parser that builds XML trees
Owners: jfearn
Branches: F-8 EL-4 EL-5
InitialCC: mdious
Cvsextras Commits: yes

Thanks, cvs admin done.

Built OK.

http://koji.fedoraproject.org/koji/taskinfo?taskID=371252

Package Change Request
======================
Package Name: perl-XML-TreeBuilder
New Branches: el6
Owners: rlandmann

Git done (by process-git-requests).