Bug 427508
| Summary: | Review Request: hunspell-hi - Hindi hunspell dictionaries | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Parag Nemade <pnemade> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eng-i18n-bugs, fedora-package-review, kevin, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-01-07 07:14:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Parag Nemade
2008-01-04 10:59:24 UTC
As with the other package, you should include the Copyright file as %doc. That's the only issue I see, so I'll go ahead and approve this and you can fix it when you check in. * source files match upstream: 2e78f20096dfa254fe92ea7cf6ec3ed19cdf664e68eea964c56651c8e79e8345 hi-demo.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: hunspell-hi = 20050726-1.fc9 = hunspell * %check is not present; I don't know any Hindi so I cannot test this. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * acceptable content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED New Package CVS Request ======================= Package Name: hunspell-hi Short Description: Hindi hunspell dictionaries Owners: pnemade Branches: F-8 InitialCC: Cvsextras Commits: no cvs done. Any particular reason to disallow cvsextras? make it yes. I have no problem in making cvsextras commit to yes. Built for devel and F-8 successfully. Thanks to tibbs and kevin. ok. Done. Thanks. |