Bug 427510

Summary: Review Request: hunspell-pa - Punjabi hunspell dictionaries
Product: [Fedora] Fedora Reporter: Parag Nemade <pnemade>
Component: Package ReviewAssignee: Jason Tibbitts <j>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eng-i18n-bugs, fedora-package-review, notting
Target Milestone: ---Flags: j: fedora-review+
petersen: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-01-07 07:14:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Parag Nemade 2008-01-04 10:59:29 UTC
Spec URL: http://paragn.fedorapeople.org/hunspell/hunspell-pa.spec
SRPM URL: http://paragn.fedorapeople.org/hunspell/hunspell-pa-20050726-1.fc8.src.rpm
Description: Punjabi hunspell dictionaries

Comment 1 Parag Nemade 2008-01-06 04:44:25 UTC
Updated links with adding Copyright file
Spec URL: http://paragn.fedorapeople.org/hunspell/hunspell-pa.spec
SRPM URL: http://paragn.fedorapeople.org/hunspell/hunspell-pa-20050726-2.fc8.src.rpm

Comment 2 Jason Tibbitts 2008-01-07 02:49:40 UTC
* source files match upstream:
   8cfb064f130688a668ec431ea22def9561fccc07968611b8f2de2f92a9e025b7  
   pa-demo.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none).
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   hunspell-pa = 20050726-2.fc9
  =
   hunspell
* %check is not present; no test suite upstream.  I could not test this package.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Comment 3 Parag Nemade 2008-01-07 03:37:47 UTC
Thanks tibbs for review.

New Package CVS Request
=======================
Package Name: hunspell-pa
Short Description: Punjabi hunspell dictionaries
Owners: pnemade
Branches: F-8
InitialCC: 
Cvsextras Commits: yes

Comment 4 Jens Petersen 2008-01-07 05:51:51 UTC
cvs admin done

Comment 5 Parag Nemade 2008-01-07 07:14:50 UTC
Built for devel and F-8 successfully.
Thanks to tibbs and Jens.