Bug 427512

Summary:	Review Request: hunspell-ta - Tamil hunspell dictionaries
Product:	[Fedora] Fedora	Reporter:	Parag Nemade <pnemade>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eng-i18n-bugs, fedora-package-review, notting
Target Milestone:	---	Flags:	j: fedora-review+ petersen: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-01-07 07:15:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Parag Nemade 2008-01-04 10:59:37 UTC

Spec URL: http://paragn.fedorapeople.org/hunspell/hunspell-ta.spec
SRPM URL: http://paragn.fedorapeople.org/hunspell/hunspell-ta-20060222-1.fc8.src.rpm
Description: Tamil hunspell dictionaries

Comment 1 Parag Nemade 2008-01-06 04:44:38 UTC

Updated links with adding Copyright file
Spec URL: http://paragn.fedorapeople.org/hunspell/hunspell-ta.spec
SRPM URL: http://paragn.fedorapeople.org/hunspell/hunspell-ta-20060222-2.fc8.src.rpm

Comment 2 Jason Tibbitts 2008-01-07 02:59:18 UTC

I don't see any mention of the GPL version in use; how did you determine that
the file is under GPLv2+?  It seems that without any explicit mention, GPL+ is
appropriate.

Otherwise this package is fine.  The issue is pretty minor; I'll go ahead and
approve this package and you can double check the GPL version when you check in.

* source files match upstream:
   c3ff9fe4f17dc204c983ee62add444342be5d6b1ff306ab2c6e47711b707b3b8  
   ta-demo.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
? license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none)
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   hunspell-ta = 20060222-2.fc9
  =
   hunspell
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* acceptable content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Comment 3 Parag Nemade 2008-01-07 03:12:48 UTC

tibbs,
   I determined version based on COPYING file. I got confused on 2 license files
and took COPYING as main license file.

Comment 4 Parag Nemade 2008-01-07 03:39:14 UTC

Thanks tibbs for review. 
Will make License tag to GPL+ while cvs import.

New Package CVS Request
=======================
Package Name: hunspell-ta
Short Description: Tamil hunspell dictionaries
Owners: pnemade
Branches: F-8
InitialCC: 
Cvsextras Commits: yes

Comment 5 Jens Petersen 2008-01-07 05:51:59 UTC

cvs admin done

Comment 6 Parag Nemade 2008-01-07 07:15:17 UTC

Built for devel and F-8 successfully.
Thanks to tibbs and Jens.