Bug 427722
| Summary: | Review Request: xsettings-kde - XSettings Daemon for KDE | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> | ||||
| Component: | Package Review | Assignee: | manuel wolfshant <manuel.wolfshant> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review, iboverma, notting | ||||
| Target Milestone: | --- | Flags: | manuel.wolfshant:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 0.6-3.fc8 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-05-10 13:52:33 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Rex Dieter
2008-01-07 03:38:40 UTC
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=329974 rpmlint clean. Tested only in a KDE3 envionment (so far). I've confirmed that this does *not* work in kde4. Haven't had a chance to dissect the code to determine why. It's almost OK, but a couple of fixes are needed
- please settle with either $RPM_BUILD_ROOT or %{buildroot}; you are using each
version twice
- as far as I understand, upstream is Mandriva's svn; please add a comment
indicating the manner to replicate the source file that you have included (bonus
points for mentioning the exact version )
- your make line does not include the magic %{?_smp_mflags}
- the source tar includes COPYING, therefore the final rpm should contain it, too
- I assume that not using desktop-file-install is intentional ?
I've attached a modified spec which fixes points 1-3 above.
Created attachment 293067 [details]
modified spec
modified spec
- includes a comment describing the method to download upstream sources
- small cosmetic fixes
- packages the license file
thx, updated finally (sorry, f9 madness). %changelog * Sun Jan 27 2008 Manuel Wolfshant <wolfy> 0.6-3 - small fixes Spec URL: http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/xsettings-kde/xsettings-kde.spec SRPM URL: http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/xsettings-kde/xsettings-kde-0.6-3.src.rpm scratch build: F-8: http://koji.fedoraproject.org/koji/taskinfo?taskID=595901 APPROVED New Package CVS Request ======================= Package Name: xsettings-kde Short Description: XSettings Daemon for KDE Owners: rdieter Branches: F-7 F-8 EL-5 Cvsextras Commits: yes cvs done. (Also did a F-9 branch). xsettings-kde-0.6-3.fc7 has been submitted as an update for Fedora 7 xsettings-kde-0.6-3.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. xsettings-kde-0.6-3.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. |