Bug 428114
Summary: | Review Request: perl-User - API for locating user information regardless of OS | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Xavier Bachelot <xavier> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-01-09 21:13:02 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 428115 |
Description
Xavier Bachelot
2008-01-09 10:52:07 UTC
I don't think you need %check ||: make it %check only. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url b8b2c677dc4ef08e84b5b4f8cb021540 User-1.8.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave PERL_DL_NONLAZY=1 /usr/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl 1..3 # Running under perl version 5.008008 for linux # Current time local: Wed Jan 9 06:21:40 2008 # Current time GMT: Wed Jan 9 11:21:40 2008 # Using Test.pm version 1.25 ok 1 ok 2 ok 3 + Package perl-User-1.8-1.fc9 -> Provides: perl(User) = 1.8 Requires: perl(:MODULE_COMPAT_5.8.8) perl(Exporter) perl(strict) perl(vars) APPROVED. Thx Parag. %make check fixed in : http://washington.kelkoo.net/fedora/SPECS/perl-User.spec http://washington.kelkoo.net/fedora/SRPMS/perl-User-1.8-2.fc8.src.rpm New Package CVS Request ======================= Package Name: perl-User Short Description: API for locating user information regardless of OS Owners: xavierb Branches: F-8 InitialCC: Cvsextras Commits: yes cvs done. Thanks Kevin. Imported and built for devel and F-8. |