Bug 428228

Summary: Review Request: OpenEXR_Viewers - Viewers programs for OpenEXR
Product: [Fedora] Fedora Reporter: Nicolas Chauvet (kwizart) <kwizart>
Component: Package ReviewAssignee: Rex Dieter <rdieter>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, rdieter
Target Milestone: ---Flags: rdieter: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-05-10 21:50:17 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 403741    
Bug Blocks:    

Description Nicolas Chauvet (kwizart) 2008-01-10 02:26:59 UTC
Spec URL:
http://kwizart.fedorapeople.org/SPECS/OpenEXR_Viewers.spec
SRPM URL:
http://kwizart.fedorapeople.org/SRPMS/OpenEXR_Viewers-1.0.1-1.kwizart.fc8.src.rpm
Description: Viewers programs for OpenEXR

Comment 1 Rex Dieter 2008-05-09 16:15:00 UTC
finally a round-tuit.

Eww, alternatives, but looks like there's no choice here if you want to try to
provide the extra (non-modular) functionality.

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=602465

Comment 2 Rex Dieter 2008-05-09 16:47:11 UTC
rpmlint clean.

$ md5sum *.tar.gz
e7b77c320a00cd89ef50605ba2a374cd  openexr_viewers-1.0.1.tar.gz
sources: ok
license: ok
scriptlets: ok
file list: ok

everything else is simple enough, APPROVED.



Comment 3 Rex Dieter 2008-05-09 16:49:21 UTC
Oh, one more thing, please add:
Obsoletes: OpenEXR-utils < 1.6.0

which is where exrdisplay used to be way back when... :)

Comment 4 Nicolas Chauvet (kwizart) 2008-05-09 17:22:33 UTC
Okay - Thx for the review
I wonder if I would need to add:
Provides /usr/bin/exrdisplay since i'm using an alternative name in this case?

added:
# Last version was in F-7 - Can be dropped in F-10
Obsoletes: OpenEXR-utils < 1.6.0



Comment 5 Rex Dieter 2008-05-09 17:30:47 UTC
Actually, my preference (tho some disagree with me), is to %ghost it, so that
the alternative is owned.

ie, in %install
touch %buildroot%{_bindir}/exrdisplay

and in %files
%ghost %{_bindir}/exrdisplay


but, Provides is an option too, I'll leave that up to you.

Comment 6 Nicolas Chauvet (kwizart) 2008-05-09 21:08:33 UTC
New Package CVS Request
=======================
Package Name: OpenEXR_Viewers
Short Description: Viewers programs for OpenEXR
Owners: kwizart
Branches: F-8 F-9 EL-5
Cvsextras Commits: yes



Comment 7 Kevin Fenzi 2008-05-10 04:09:47 UTC
cvs done.