Bug 428576
Summary: | Review Request: mkelfimage - Utility to create ELF boot images from Linux kernel images | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jason Tibbitts <j> |
Component: | Package Review | Assignee: | Matt Domsch <matt_domsch> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, matt_domsch, notting |
Target Milestone: | --- | Flags: | matt_domsch:
fedora-review+
j: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-01-19 20:21:00 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 188611 |
Description
Jason Tibbitts
2008-01-13 17:32:08 UTC
* rpmlint completely empty OK * Name OK * SPEC file name matches package name OK * Packaging - Legal GPLv2 OK - no pre-built binaries OK - FHS dirs OK - changelog OK - tags OK - BuildRoot OK, could be better - prepping buildroot OK - no Requires OK - no PreReq ok - Summary & description OK - Encoding UTF-8 OK - no non-ascii filenames OK - %docs OK - compiler flags passed by %configure w/o changes, OK - debuginfo created OK - no static libs OK - no duplication of system libs OK - no rpaths OK - no config files OK - no initscripts OK - no desktop files OK - macros sane OK - no locale files OK - no file copying OK - parallel make OK - no scriptlets OK - no conditional deps OK - builds as another user OK - not relocatable OK - code, not content. OK - dirs owned by filesystem pkg OK - no user and groups created OK - not a web app OK - no conflicts OK - no external kernel modules OK * License GPLv2 OK * License field matches OK * License COPYING included in %doc OK * Spec in English OK * Spec legible OK * source matches upstream tarball OK * package compiles on i386 at least OK * no extra BuildRequires OK * no locales OK * no shared libs OK * not relocatable OK * dir ownership OK * no dupe files OK * permissions on files OK, defaddr present OK * %clean OK * use of macros OK * code, not content OK * no large docs OK * no headers OK * no static libs OK * no pkgconfig OK * no lib files OK * no devel package needed OK * no .la files OK * no GUI apps, therefore no .desktop file OK * directory ownership OK * %install cleans out first OK * all filesnames in UTF-8 OK SHOULD * license included OK * not translated, OK * builds in mock for i386 and x86_64 * did not run it - SHOULD DO - leave up to LTSP dev / test team * no scriptlets OK * no subpackages OK * no pkgconfig files OK * no file deps OK Nits: * license is GPLv2 per manpage, remove comment in spec at checkin. APPROVED. Thanks, Matt! As the reviewer, this ticket should be assigned to you so I'll go ahead and do that now. I'll also do my own CVS. Package Name: mkelfimage Short Description: Utility to create ELF boot images from Linux kernel images Owners: warren tibbs Branches: F-8 InitialCC: Cvsextras Commits: yes Built and in rawhide now I see. Closing. |