Bug 428777
Summary: | Review Request: perl-Net-NBName - Net::NBName perl module | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Walter Gould <gouldwp> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 0.26-2.fc8 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-01-27 07:17:44 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Walter Gould
2008-01-15 05:38:01 UTC
This one build OK; rpmlint says: perl-Net-NBName.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-Net-NBName-0.26/README perl-Net-NBName.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-Net-NBName-0.26/Changes perl-Net-NBName.noarch: E: wrong-script-end-of-line-encoding /usr/bin/nodescan.pl perl-Net-NBName.noarch: E: wrong-script-end-of-line-encoding /usr/bin/nodestat.pl perl-Net-NBName.noarch: E: wrong-script-end-of-line-encoding /usr/bin/namequery.pl All of these can be fixed with a quick pass through sed; see http://fedoraproject.org/wiki/PackageMaintainers/CommonRpmlintIssues perl-Net-NBName.noarch: E: script-without-shebang /usr/bin/nodescan.pl perl-Net-NBName.noarch: E: script-without-shebang /usr/bin/nodestat.pl perl-Net-NBName.noarch: E: script-without-shebang /usr/bin/namequery.pl These scripts are executable, but the first line of each doesn't contain the '#!' line that would enable the kernel to know how to run them. As a result these scripts do nothing except spew shell errors. You will need to add #!/usr/bin/perl to each. Checklist: * source files match upstream: 947cf41234f88779086f851748a86b04bf6f851f0d84b8950c8e3fbdbf20cd2e Net-NBName-0.26.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly X rpmlint has valid complaints. * final provides and requires are sane: perl(Net::NBName) = 0.26 perl(Net::NBName::NameQuery) = 0.26 perl(Net::NBName::NameQuery::RR) = 0.26 perl(Net::NBName::NodeStatus) = 0.26 perl(Net::NBName::NodeStatus::RR) = 0.26 perl(Net::NBName::Request) perl-Net-NBName = 0.26-1.fc9 = perl(:MODULE_COMPAT_5.8.8) perl(Net::NBName::NameQuery) perl(Net::NBName::NameQuery::RR) perl(Net::NBName::NodeStatus) perl(Net::NBName::NodeStatus::RR) perl(Socket) perl(strict) perl(vars) perl(warnings) * %check is present and all tests pass: All tests successful. Files=2, Tests=23, 0 wallclock secs ( 0.08 cusr + 0.01 csys = 0.09 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. In order to correct the script-without-shebang errors that rpmlint is producing - would I need to create a patch to include the shebang? Or, could I just change it w/o a patch? Not sure if you all frown upon changing source w/o a patch. Thanks, Walter You can just sed them in if you want; it's preferable to do this in %prep if possible. (You're just patching sources but via program instead of a patch.) Also, I'm not sure if you're asking this, but just in case, you should know that you can't just change it in the tarball. Ok, to fix the rpmlint errors I decided to add a patch (it's late and I'm not a sed expert) to include the shebang's in the three perl scripts that they were missing from. Also, I include a couple of sed lines in the %prep section to fix the file-end-of-line-encoding for README and Changes. Here are the new urls: Spec: http://niscripts.googlecode.com/svn/trunk/rpms/SPECS/perl-Net-NBName.spec SRPM: http://niscripts.googlecode.com/svn/trunk/rpms/SRPMS/perl-Net-NBName-0.26-2.fc8.src.rpm Looks good to me. APPROVED Just one more to go. New Package CVS Request ======================= Package Name: perl-Net-NBName Short Description: Net::NBName perl module Owners: gouldwp Branches: F-8 EL-5 InitialCC: Cvsextras Commits: yes cvs done. perl-Net-NBName-0.26-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |