Bug 428830
Summary: | Review Request: python-pyasn1 - ASN.1 tools for Python | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Rob Crittenden <rcritten> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-01-18 15:37:44 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Rob Crittenden
2008-01-15 14:58:48 UTC
Good to have %install as %install rm -rf $RPM_BUILD_ROOT %{__python} setup.py install --skip-build --root $RPM_BUILD_ROOT and %files as %files %defattr(-,root,root,-) %doc README LICENSE examples/* %{python_sitelib}/* Yes, simpler is better, thanks. New files uploaded: Spec URL: http://rcritten.fedorapeople.org/python-pyasn1.spec SRPM URL: http://rcritten.fedorapeople.org/python-pyasn1-0.0.7a-4.fc7.src.rpm Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 8dd0a5e1465ab3fd1b095aee812c2091 pyasn1-0.0.7a.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. SHOULD: * Remove following unnecessary line from SPEC %define vermodule %{module}-%{version}/pyasn1 APPROVED. Ok, I'll fix those things up when I commit it. New Package CVS Request ======================= Package Name: python-pyasn1 Short Description: ASN.1 tools for Python Owners: rcritten Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes cvs done. |