Bug 428833

I updated to 2.21.5.1, but it turned out that it doesn't build. Waiting for a
fixes upstream release before attaching a mock-proof spec...

Updated spec and srpm here:
http://people.redhat.com/mclasen/gnome-settings-daemon.spec
http://people.redhat.com/mclasen/gnome-settings-daemon-2.21.5.2-1.src.rpm

These build in mock. 

rpmlint output:

[mclasen@localhost Desktop]$ rpmlint
/var/lib/mock/fedora-development-i386/result/gnome-settings-daemon-2.21.5.2-1.fc9.i386.rpm

gnome-settings-daemon.i386: W: non-conffile-in-etc
/etc/gconf/schemas/desktop_gnome_font_rendering.schemas
gnome-settings-daemon.i386: W: non-conffile-in-etc
/etc/gconf/schemas/apps_gnome_settings_daemon_screensaver.schemas
gnome-settings-daemon.i386: W: non-conffile-in-etc
/etc/gconf/schemas/gnome-settings-daemon.schemas
gnome-settings-daemon.i386: W: non-conffile-in-etc
/etc/gconf/schemas/apps_gnome_settings_daemon_keybindings.schemas
gnome-settings-daemon.i386: W: non-conffile-in-etc
/etc/gconf/schemas/apps_gnome_settings_daemon_default_editor.schemas
[mclasen@localhost Desktop]$ rpmlint
/var/lib/mock/fedora-development-i386/result/gnome-settings-daemon-*.rpm 
gnome-settings-daemon.i386: W: non-conffile-in-etc
/etc/gconf/schemas/desktop_gnome_font_rendering.schemas
gnome-settings-daemon.i386: W: non-conffile-in-etc
/etc/gconf/schemas/apps_gnome_settings_daemon_screensaver.schemas
gnome-settings-daemon.i386: W: non-conffile-in-etc
/etc/gconf/schemas/gnome-settings-daemon.schemas
gnome-settings-daemon.i386: W: non-conffile-in-etc
/etc/gconf/schemas/apps_gnome_settings_daemon_keybindings.schemas
gnome-settings-daemon.i386: W: non-conffile-in-etc
/etc/gconf/schemas/apps_gnome_settings_daemon_default_editor.schemas
gnome-settings-daemon.src: W: mixed-use-of-spaces-and-tabs (spaces: line 37,
tab: line 1)
gnome-settings-daemon-devel.i386: W: no-documentation

I'll fix the spaces/tabs thing, the rest are ignorable


package name: ok
spec file name: ok
packaging guidelines: ok
license: ok
license field: ok
license file: ok
spec file language: ok
spec file readable: yes
upstream sources: ok
buildable: yes
excludearch: n/a
buildrequires: ok
locale handling: ok
shared libs: n/a
relocatable: n/a
directory ownership: need to own /usr/include/gnome-settings-daemon-2.0
%file list: ok
permissions: need to add %defattr to devel file list
%clean: ok
macro use: consistent
content: code
large docs: n/a
%doc content: ok
header files: ok
static libs: n/a
pkgconfig files: ok
libraries: n/a
devel deps: ok
.la files: n/a
gui app: n/a
file ownership: ok
%install: ok
utf8: ok

All fixed in 

http://people.redhat.com/mclasen/gnome-settings-daemon.spec
http://people.redhat.com/mclasen/gnome-settings-daemon-2.21.5.2-2.src.rpm

Approved.

New Package CVS Request
=======================
Package Name: gnome-settings-daemon 
Short Description: A daemon to share settings from GNOME to other applications
Owners: bnocera
Branches: 
InitialCC: 
Cvsextras Commits:

Humm... this review looks very strange. No comments at all from the submitter,
and the reviewer fixing and approving the package. 

Bastien: are you going to maintain this package? 

I did the work on both sides of the review here, since Bastian was already gone,
and I wanted this finished... it is not a big deal anyway, this is just a part
of the control-center package that Bastian already maintains, broken out as a
separate package. 

(In reply to comment #7)
<snip>
> Bastien: are you going to maintain this package? 

Yes, not that it makes much difference. The code is what used to be in the
control-center, so it's just a split out package.

How about I do another review here just to check over everything and then you
guys can co-maintain it? 

I can do that later tonight...

I've done one.

rpmlint only complains about schema files, which aren't config files so not
being marked as %config is fine.

gnome-settings-daemon.i386: W: non-conffile-in-etc
/etc/gconf/schemas/desktop_gnome_font_rendering.schemas
gnome-settings-daemon.i386: W: non-conffile-in-etc
/etc/gconf/schemas/apps_gnome_settings_daemon_screensaver.schemas
gnome-settings-daemon.i386: W: non-conffile-in-etc
/etc/gconf/schemas/gnome-settings-daemon.schemas
gnome-settings-daemon.i386: W: non-conffile-in-etc
/etc/gconf/schemas/apps_gnome_settings_daemon_keybindings.schemas
gnome-settings-daemon.i386: W: non-conffile-in-etc
/etc/gconf/schemas/apps_gnome_settings_daemon_default_editor.schemas
gnome-settings-daemon-devel.i386: W: no-documentation


It builds fine in mock

Name/Summary/Description is fine
License is correct
source tarball matches the sha1sum
source line matches upstream location
Buildroot is acceptable
BuildRequires all look fine
as do all the other Requires
scriptlets are sane
files are sane

Passes review.

Could someone please create the CVS repo now? Thanks.

cvs done. 

Sorry to hassle you guys. 

Kevin, could you please fix the permissions on the module for me?
**** Access denied: hadess is not in ACL for rpms/gnome-settings-daemon/devel

Thanks.

When did you try? The acl cron job runs twice an hour... perhaps just try again
after the top of the hour? You should be set as owner... 

Done, gnome-settings-daemon-2.21.5.2-2.fc9 built in rawhide. Thanks Kevin.