Bug 429443
| Summary: | Review Request: fantasdic - Dictionary application using Ruby | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mamoru TASAKA <mtasaka> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-01-22 06:02:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Mamoru TASAKA
2008-01-20 04:42:11 UTC
Builds fine and seems to work well enough.
I don't understand why you have
BuildRequires: ruby(abi) = %{rubyabi}
I don't suppose it hurts anything, except to prevent this from building if the
ABI happens to change.
I thought it odd that --without-scrollkeeper is passed to setup.rb, but it looks
like the files make it to the right place. Actually for an application this
simple the spec is amazingly complex, but it all seems to work so I don't see
any real problems with it.
* source files match upstream:
7c05264b53f24e8738977f27ef7015cda952505461ad7b45a1f7fddeaa7835c2
fantasdic-1.0-beta5.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
? BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
fantasdic = 1.0-0.1.beta5.fc9
=
/bin/sh
/usr/bin/ruby
ruby
ruby(abi) = 1.8
ruby(gconf2)
ruby(gettext-package)
ruby(gnome2)
ruby(gtk2)
ruby(libglade2)
scrollkeeper
* %check is not present; no test suite upstream. I installed this package and
it seems to work well enough.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (scrollkeper, icon cache)
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* desktop file looks correct and is installed properly.
* Localization files are installed properly.
APPROVED
Thank you! (In reply to comment #1) > I don't understand why you have > BuildRequires: ruby(abi) = %{rubyabi} > I don't suppose it hurts anything, except to prevent this from building if the > ABI happens to change. Yes. Without this when ruby is updated to 1.9 the srpm can still be rebuilt but the rebuilt binary rpm requires ruby 1.8, which I want to avoid. > I thought it odd that --without-scrollkeeper is passed to setup.rb, but it looks > like the files make it to the right place. Yes. from data/omf/fantasdic/post-install.rb (and from "ruby setup.rb --help") this option supresses the execution of "scrollkeeper" command on installation and this is not for not installing omf files. New Package CVS Request ======================= Package Name: fantasdic Short Description: Dictionary application using Ruby Owners: mtasaka Branches: F-8 F-7 InitialCC: Cvsextras Commits: yes cvs done. Rebuilt on all branches, requested on bodhi to push, closing. Thank you for the review and CVS procedure! |