Bug 429483
| Summary: | Review Request: o3read - Standalone converter for OpenOffice.org documents | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Deji Akingunola <dakingun> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, lam, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-01-22 00:46:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Deji Akingunola
2008-01-20 22:26:02 UTC
*** Bug 398321 has been marked as a duplicate of this bug. *** This is pretty simple; it builds fine, rpmlint is silent and I can't fine any issues. * source files match upstream: 3704b448099d3396bec4cf503c298628c815703aae12bfcddbac4444bc786430 o3read-0.0.4.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper (none). * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane. * %check is not present; no test suite upstream. I did some light testing and things seem to work as advertised. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED This package looks very promising. It basically is everything I've asked for! :) I can't really review the spec, but it builds, installs and works (at least o3totxt) under F8 just fine. After this packages passes the review, are you willing to contact Midnight Commander's maintainer to add a dependency on o3read, which is the second part of my proposal? :) Thanks Jason for the quick review. @ Leszek, I think you're in the best position to contact Midnight Commander's maintainer about the second part of your proposal. I don't use MC, neither do I know how o3read (o3totxt) is useful for it. New Package CVS Request ======================= Package Name: o3read Short Description: Standalone converter for OpenOffice.org documents Owners: deji Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes cvs done. Successfully built for rawhide. Package Change Request ====================== Package Name: o3read New Branches: EL-4 EL-5 Owners: deji CVS done. |