Bug 430071
| Summary: | Review Request: igraph - Library for creating and manipulating graphs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Neal Becker <ndbecker2> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bstinson, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-01-30 19:22:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Neal Becker
2008-01-24 12:21:10 UTC
Changes need 1) summary of -devel should be Summary: Development files for igraph 2) Not following shared libs scriptlet http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-d0dbcb7eec27622a21df280009c5b089b02f5bef Drop Requires(post): /sbin/ldconfig 3) follow texinfo scriptlet http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-47896da5fb2662d75deefeb9ba75145a398515db missing || : from %post devel 4) -devel is installing .pc file so -devel should Requires:pkgconfig 5) No need of License tag in -devel 6) Description should be written like igraph wants to be an efficient platform for 1) complex network analysis and 2) developing and implementing graph algorithms. It provides flexible and efficient data structures for graphs and related tasks. It also provides implementation to many classic and new graph algorithms like: maximum flows, graph isomorphism, scale-free networks, community structure finding, etc. Provide updated SRPM fixing above issues Please see new srpm fixing all the above: https://nbecker.dyndns.org/RPM/igraph-0.4.5-2.fc8.src.rpm above looks good.
1)I saw that description also should be changed to
The %{name}-devel package contains the header files and some
documentation needed to develop application with %{name}.
2) You should add examples/simple directory as %doc for igraph-devel. Take care
not to include hidden directory .arch-ids.
I believe this addresses all above issues: https://nbecker.dyndns.org/RPM/igraph-0.4.5-3.fc8.src.rpm Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM. - rpmlint is NOT silent for RPM. igraph-devel.i386: W: wrong-file-end-of-line-encoding /usr/share/doc/igraph-devel-0.4.5/simple/igraph_write_graph_pajek.out igraph-devel.i386: W: wrong-file-end-of-line-encoding /usr/share/doc/igraph-devel-0.4.5/simple/LINKS.NET + source files match upstream url a2f462c3519eb1d49b9c5a4827358e3a igraph-0.4.5.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + igraph.pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package igraph-0.4.5-3.fc9 -> Provides: libigraph.so.0 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libigraph.so.0 libm.so.6 libm.so.6(GLIBC_2.0) libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) rtld(GNU_HASH) + Package igraph-devel-0.4.5-3.fc9 -> Requires: igraph = 0.4.5-3.fc9 libigraph.so.0 pkgconfig + Not a GUI App. SHOULD: 1)change %doc examples/simple to %doc/examples and remove .arch-ids from examples also. This makes more sense for whats simple directory as its parent directory will then examples. 2)Good if you provide Makefile also in simple directory. 3) You can either resolve rpmlint messages by using iconv on those 2 files in %prep or let it be as its not problematic. APPROVED. New Package CVS Request ======================= Package Name: igraph Short Description: Library for creating and manipulating graphs Owners: nbecker Branches: F-7 F-8 InitialCC: panemade Cvsextras Commits: yes cvs done. Sorry, But I don't want to be InitialCC here or for any reviews I have done. Package Change Request ====================== Package Name: igraph New Branches: el6 epel7 Owners: pingou bstinson I would like to co-maintain igraph for EL6 and EL7. I talked to pingou on IRC, and he approved. Git done (by process-git-requests). |