Bug 430130

Summary: iscsi modules need to set the module reference in the host template
Product: Red Hat Enterprise Linux 5 Reporter: Mike Christie <mchristi>
Component: kernelAssignee: Mike Christie <mchristi>
Status: CLOSED ERRATA QA Contact: Martin Jenner <mjenner>
Severity: low Docs Contact:
Priority: low    
Version: 5.2CC: coughlan
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: RHBA-2008-0314 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-05-21 15:07:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch to set module reference none

Description Mike Christie 2008-01-24 18:05:56 UTC
Description of problem:

If the iscsi modules do not set the module reference in the scsi host template
then if iscsi is shutdown and other entities are holding a reference then they
will be referencing bad memory.

Version-Release number of selected component (if applicable):


How reproducible:

everytime


Steps to Reproduce:
1. start iscsi
2. start multipath
3. stop iscsi 
4. stop multipath and get oops
  


Actual results:

You get an oops

Expected results:

should not get a oops and the system should gracefully handle the out of order
shutdown.


Additional info:

Patch is upstream here:

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commitdiff;h=7974392c0b0d4e7a2a17ca3597d51a29b9841aa5

Comment 2 RHEL Program Management 2008-01-24 18:07:22 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 3 Tom Coughlan 2008-01-24 18:20:28 UTC
Mike says this is not critical for 1st beta release. It should go in an early 
snapshot.   

Comment 4 Mike Christie 2008-01-24 18:59:40 UTC
Created attachment 292841 [details]
patch to set module reference

Here is the patch I am sending to rh kernel. It is a really simple two liner.

Comment 6 Don Zickus 2008-01-30 17:02:01 UTC
in 2.6.18-76.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Comment 9 errata-xmlrpc 2008-05-21 15:07:25 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2008-0314.html