Bug 430249

Summary: neofb: avoid overwriting fb_info fields
Product: Red Hat Enterprise Linux 5 Reporter: Jan Lieskovsky <jlieskov>
Component: kernelAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED ERRATA QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: 5.0CC: kreilly, vdanen
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: impact=low,public=20071221,reported=20071214,source=kernelbz
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-03-10 21:44:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 430250, 430251, 430252, 430253, 430254    
Bug Blocks:    

Description Jan Lieskovsky 2008-01-25 15:51:17 UTC 
Description of problem:

Marcio Buss has reported a multiple possible buffer overflows in the
Linux kernel Neofb video driver. 

<cite>

On file drivers/video/neofb.c it seems there are multiple buffer overrrun
errors involving "info->fix.id" For example, on line 2103 the statement

sprintf(info->fix.id, "MagicGraph 256XL+");

writes 18 bytes (including the terminator character) into info->fix.id,
yet fix.id is only 16 bytes long. Is there any catch here, or the programmer
did overlook the lenght of "id"?

</cite>

Comment from Andrew Morton:

"I queued neofb-avoid-overwriting-fb_info-fields.patch to address this."

Upstream URL of this problem:

http://bugzilla.kernel.org/show_bug.cgi?id=9565

Patch provided (and mentioned by Andrew Morton): 

http://www.mail-archive.com/mm-commits@vger.kernel.org/msg31424.html
Comment 3 Vincent Danen 2009-03-10 21:44:49 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link(s) below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2008-0314.html
http://rhn.redhat.com/errata/RHSA-2008-0233.html