Bug 430541
| Summary: | Review Request: taskcoach - Your friendly task manager | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Krzysztof Kurzawski <kurzawax> | ||||
| Component: | Package Review | Assignee: | José Matos <jamatos> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | rawhide | CC: | fedora-package-review, notting | ||||
| Target Milestone: | --- | Flags: | jamatos:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-02-08 10:52:06 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Krzysztof Kurzawski
2008-01-28 18:02:01 UTC
Hi Krzysztof,
I cannot sponsor you, but I'm unofficially reviewing your package.
Your spec looks fine, rpmlint doesn't complain about anything and building
the rpm was just fine.
So I guess your packaging is just perfect.
Ok, thanks for review! Are you sure that the dependency on python 2.5 is correct? Looking into the news it seems that the correct dependency is 2.4. Another question: did you change the spec file after submission? I seem to remember a different spec file when I first looked into it last Monday. In this case it would be nice to increment the release number nevertheless. FWIW I am also guilty of doing that, but while reviewer you get to see the other side. :-) Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/taskcoach/taskcoach.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/taskcoach/taskcoach-0.68.0-2.fc8.src.rpm Thanks for review! Can anybody review this? I will do it today. The last few days here were Carnival so I took some time off. I intend to publish the formal review still later today. The package fails to build in rawhide due to the egg-info file not being declared in %files. See http://fedoraproject.org/wiki/PackagingDrafts/PythonEggs for further details. The fix is easy. :-) Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/taskcoach/taskcoach.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/taskcoach/taskcoach-0.68.0-3.fc8.src.rpm Created attachment 294196 [details]
patch to spec file
The egg-info file name is different. :-)
The patch attached has three changes:
Fixes the egg-info location.
Excludes the buildlib directory that seems to be used only at build time.
Reorders the file section (it is a matter of style) to put similar items
together.
Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/taskcoach/taskcoach.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/taskcoach/taskcoach-0.68.0-4.fc8.src.rpm One final note, as I have found out while trying this package in rawhide, you need to add a Requires wxPython because that is not caught in the automatic dependencies. :-( It would be nice to have automatic python dependencies like there are for dynamic libraries or perl modules. We can dream. :-) There are no additional requirements to this package so it is APPROVED. You can fix the above problem when importing. Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/taskcoach/taskcoach.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/taskcoach/taskcoach-0.68.0-5.fc8.src.rpm New Package CVS Request ======================= Package Name: taskcoach Short Description: Your friendly task manager Owners: kurzawa Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes cvs done. Imported and built. Thanks again for review! |