Bug 430859
Summary: | Review Request: netmonitor - The free linux network bandwidth monitor | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Krzysztof Kurzawski <kurzawax> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, notting, terje.rosten |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-01-31 22:04:09 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Krzysztof Kurzawski
2008-01-30 10:03:35 UTC
The place of the "./configure" line is in %build, not in %prep, and unless there is a very good reason to not do it, it should probably be replaced with "%configure <any needed parameters>" Suggestions:- Apply following patch which resolves 1) compiler flags not honored issue 2) remove unneeded "make install" call 3) remove unnecessary INSTALL file ============================================================================== %prep -%setup -q -n %{name}-0.4b -./configure --libdir=%{_libdir} +%setup -q -n %{name}-0.4b %build -#nothing to build +./configure --libdir=%{_libdir} --prefix=%{_prefix} +%{__make} CFLAGS="$RPM_OPT_FLAGS" %{?_smp_mflags} %install rm -rf $RPM_BUILD_ROOT mkdir -p $RPM_BUILD_ROOT%{_bindir} mkdir -p $RPM_BUILD_ROOT%{_mandir}/man1 -make install DESTDIR=%{buildroot} -cp -p src/%{name} $RPM_BUILD_ROOT%{_bindir} -cp -p src/%{name}.1 $RPM_BUILD_ROOT%{_mandir}/man1 +install -p -m755 src/%{name} $RPM_BUILD_ROOT%{_bindir} +install -p -m644 src/%{name}.1 $RPM_BUILD_ROOT%{_mandir}/man1 %clean rm -rf $RPM_BUILD_ROOT %files %defattr(-,root,root,-) -%doc README INSTALL TODO COPYING NEWS AUTHORS ChangeLog -%exclude /usr/local/bin/%{name} -%exclude /usr/local/man/man1/%{name}.1 +%doc README TODO COPYING NEWS AUTHORS ChangeLog %{_mandir}/man1/%{name}.1.gz %{_bindir}/%{name} ============================================================================= When I tried to create patch I got some encoding issue to include pl language description to be included in patch so pasting here directly. oh yes. Change ./configure to %configure in above patch Fixed. Spec URL: http://kurzawa.nonlogic.org/rpm/netmonitor/netmonitor.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/netmonitor/netmonitor-0.5-1.fc8.src.rpm Thanks for review! Sorry for my mistake. Spec URL: http://kurzawa.nonlogic.org/rpm/netmonitor/netmonitor.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/netmonitor/netmonitor-0.5-2.fc8.src.rpm Nice. You got better SPEC than what I suggested based on your initial SPEC. But I see that your SPEC in SRPM still contains INSTALL file Also, I confused on bloc word in changelog. You can use section word instead of that. Fixed. Spec URL: http://kurzawa.nonlogic.org/rpm/netmonitor/netmonitor.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/netmonitor/netmonitor-0.5-3.fc8.src.rpm Some pedantic issue: You are using $RPM_BUILD_ROOT and %{buildroot}: rm -rf $RPM_BUILD_ROOT make install DESTDIR=%{buildroot} it's the same thing, use pick one and use that. There are no make step %build, it that correct? Fixed. Spec URL: http://kurzawa.nonlogic.org/rpm/netmonitor/netmonitor.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/netmonitor/netmonitor-0.5-4.fc8.src.rpm I think here is nothing to build. README clearly suggests that To compile netmon type the following command ./configure ./make ./make install Add make command to build section make %{?_smp_mflags} Fixed. Spec URL: http://kurzawa.nonlogic.org/rpm/netmonitor/netmonitor.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/netmonitor/netmonitor-0.5-5.fc8.src.rpm Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream. fefca04be4b7272955fe5a5c93232842 netmonitor-0.5.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Not a GUI app. APPROVED. New Package CVS Request ======================= Package Name: netmonitor Short Description: The free linux network bandwidth monitor Owners: kurzawa Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes More pedantic things: if you change make install line to make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p" the timestamps will be preserved (which is good thing). Fixed. Spec URL: http://kurzawa.nonlogic.org/rpm/netmonitor/netmonitor.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/netmonitor/netmonitor-0.5-6.fc8.src.rpm cvs done. Imported and built. Thanks again for review! |