Bug 430904

Summary: [RHEL5]: xend and xendomains init scripts have wrong return values
Product: Red Hat Enterprise Linux 5 Reporter: Eduard Benes <ebenes>
Component: xenAssignee: Michal Novotny <minovotn>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 5.1CC: areis, llim, xen-maint
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-09-02 10:10:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Values correction
none
Updated patch
none
Final version of patch none

Description Eduard Benes 2008-01-30 14:26:19 UTC 
Description of problem:
The init scripts  '/etc/init.d/xend' and '/etc/init.d/xendomains' return some 
incorrect error codes. Some part of it also prevent the correct status command 
call. For example:
# /etc/init.d/xend status
+ RETVAL=0
+ '[' '!' -d /proc/xen ']'
+ exit 0
# ll /proc/xen
ls: /proc/xen: No such file or directory

Version-Release number of selected component (if applicable):
all

How reproducible:
always

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
When fixing this bug, please obbey our init script guidelines and be sure that
status command is run correctly.
Our guidelines are on following two pages:
http://intranet.corp.redhat.com/ic/intranet/InitscriptsSpec.html
http://intranet.corp.redhat.com/ic/intranet/InitscriptGuidelines.html

For an example of the script that returns the error codes correctly and always
runs status see:
http://devserv.devel.redhat.com/~mmarcini/amd
Comment 2 Michal Novotny 2009-03-16 13:25:59 UTC 
Created attachment 335344 [details]
Values correction

This is values correction patch for xen init scripts, tried to match specifications at those URLs. Anyway some links on those pages should be reviewed because pages doesn't exist at all.
Comment 3 Michal Novotny 2009-03-16 16:08:56 UTC 
Created attachment 335363 [details]
Updated patch

This is an updated version of my patch, mainly not to report errors when on running non-Xen kernel.
Comment 4 Michal Novotny 2009-03-19 13:28:40 UTC 
Created attachment 335845 [details]
Final version of patch

Final version of patch described above...
Comment 5 Jiri Denemark 2009-03-20 13:52:00 UTC 
Fix built into xen-3.0.3-83.el5
Comment 9 errata-xmlrpc 2009-09-02 10:10:54 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-1328.html