Bug 431156
| Summary: | Review Request: ruby-openid - Ruby library for verifying and serving OpenID identities | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Allisson Azevedo <allisson> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-02-11 03:05:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Allisson Azevedo
2008-02-01 02:16:36 UTC
For 2.0.3-1:
* Unneeded CFLAGS
- export CFLAGS=... can be (and should be) removed because
this is noarch package.
! Check
- Please add:
------------------------------------------------------------
%check
export RUBYLIB=$RPM_BUILD_ROOT%{ruby_sitelib}
# some tests need net connection
ruby setup.rb test || :
------------------------------------------------------------
Some tests need net connection and they fail, however IMO
it is better not to skip all tests because of net connection
missing.
? Documents split
-------------------------------------------------------------
[tasaka1@localhost ruby-openid-2.0.3]$ du -sh lib/
380K lib/
[tasaka1@localhost ruby-openid-2.0.3]$ du -sh doc/
3.7M doc/
--------------------------------------------------------------
- The size of openid module itself is only 380K, while the size
of documents is about 10 times of that.
You may want to split documents files to a subpackage rpm?
? Examples
- Would you consider to add files under examples/ to
%doc? I don't know well about Ruby on Rails, however it seems
that there are some useful examples for RoR.
Update package: Spec URL: http://allisson.fedorapeople.org/packages/ruby-openid/ruby-openid.spec SRPM URL: http://allisson.fedorapeople.org/packages/ruby-openid/ruby-openid-2.0.3-2.fc8.src.rpm Changes: - Remove CFLAGS in build section - Create ruby-openid-doc package for docs - Add examples for doc package - Remove zero-length files in doc package - Fix file-not-utf8 Well, it seems that zero-sizes under examples should not be needed.
For example, examples/rails_openid_login_generator/openid_login_generator.rb
contains:
----------------------------------------------------------------------------
13 m.template "user_test.rb", "test/unit/user_test.rb"
----------------------------------------------------------------------------
Update package: Spec URL: http://allisson.fedorapeople.org/packages/ruby-openid/ruby-openid.spec SRPM URL: http://allisson.fedorapeople.org/packages/ruby-openid/ruby-openid-2.0.3-3.fc8.src.rpm Changes: - Remove examples for doc package (the examples is not complete for inclusion in package yet) Okay.
--------------------------------------------------------------------
This package (ruby-openid) is APPROVED by me
---------------------------------------------------------------------
New Package CVS Request ======================= Package Name: ruby-openid Short Description: Ruby library for verifying and serving OpenID identities Owners: allisson Branches: F-7 F-8 Cvsextras Commits: yes cvs done. Build done: http://koji.fedoraproject.org/koji/buildinfo?buildID=35371 F-7 http://koji.fedoraproject.org/koji/buildinfo?buildID=35370 F-8 http://koji.fedoraproject.org/koji/buildinfo?buildID=35372 F-9 Thanks for your review Mamoru. |