Bug 431161

There are unfortunately a few rpmlint warnings:

mathmap.i386: W: devel-file-in-non-devel-package
/usr/share/gimp/2.0/mathmap/new_template.c
mathmap.i386: W: devel-file-in-non-devel-package
/usr/share/gimp/2.0/mathmap/blender_opmacros.h
mathmap.i386: W: devel-file-in-non-devel-package /usr/share/gimp/2.0/mathmap/pools.h
mathmap.i386: W: devel-file-in-non-devel-package
/usr/share/gimp/2.0/mathmap/opmacros.h
mathmap.i386: W: devel-file-in-non-devel-package
/usr/share/gimp/2.0/mathmap/blender_template.c

These seem to be required for the plugin to work at runtime, despite being
source files.

mathmap.i386: W: symlink-should-be-relative /usr/lib/gimp/2.0/plug-ins/mathmap
/usr/bin/mathmap

Not sure if this matters.

mathmap.i386: E: only-non-binary-in-usr-lib

I don't think I can fix this, because the gimp plugin path isn't picked by me

First of all, rebuild doesn't succeed.
http://koji.fedoraproject.org/koji/taskinfo?taskID=398683
You can check this by koji scratch build.

From just glancing at your spec file:
- Source must be given with full URL
- Fedora specific compilation flags don't seem to be honored
  correctly.
- Would you try to use relative symlink instead of absolute one?
- When using "install" or "cp" commands, add "-p" option to keep
  timestamps on installed files.
- It seems "Requires: gimp" is needed because 
  `gimptool --gimpdatadir` is owned by gimp but not by gimp-libs.

- Source must be given with full URL

Fixed.

- Fedora specific compilation flags don't seem to be honored
  correctly.

Maybe I'm being dense, but I'm not sure what you mean.

- Would you try to use relative symlink instead of absolute one?

Fixed.

- When using "install" or "cp" commands, add "-p" option to keep
  timestamps on installed files.

Fixed.

- It seems "Requires: gimp" is needed because 
  `gimptool --gimpdatadir` is owned by gimp but not by gimp-libs.

Fixed.

New spec and srpm at:
http://people.redhat.com/rnorwood/rpms/mathmap.spec
http://people.redhat.com/rnorwood/rpms/mathmap-1.2.4-2.fc9.src.rpm

* compiler falgs
  - Well, what "Fedora specific compilation flags are not honored" means
    is related to "Compiler flags" of
    http://fedoraproject.org/wiki/Packaging/Guidelines
    When using gcc or g++, we must ensure that the compiler option specified
    as %optflags are correctly used. On rawhide i386 system, currently
    they are:
-----------------------------------------------------------------------------
[tasaka1@localhost ~]$ rpm --eval %optflags
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables
------------------------------------------------------------------------------
    However the build log (from:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=402716 )
    shows:
-------------------------------------------------------------------------------
gcc -I. -D_GNU_SOURCE -DCGEN_CC="\"gcc -O2 -c -fPIC -o\"" -DCGEN_LD="\"gcc
-shared -o\"" -O2 -Wall `gimptool-2.0 --cflags` `pkg-config --cflags gmodule-2.0
gthread-2.0 gtksourceview-1.0` -DLOCALEDIR=\"/usr/local/share/locale\"
-DTEMPLATE_DIR=\"`gimptool-2.0 --gimpdatadir`/mathmap\"
-DPIXMAP_DIR=\"`gimptool-2.0 --gimpdatadir`/mathmap\" -DENABLE_NLS 
-DMATHMAP_CMDLINE -DGIMPDATADIR=\"`gimptool-2.0 --gimpdatadir`\"
-DMATHMAP_VERSION=\"1.2.4\" -DRWIMG_JPEG -DRWIMG_PNG -DRWIMG_GIF -o
mathmap_common.o -c mathmap_common.c
-------------------------------------------------------------------------------
   , where %optflags are not correctly honored.

* LOCALEDIR
  - And as far as I checked build.log, perhaps LOCALEDIR is wrong.

ping?

I need to take the time to convince it to honor the %optflags, but I haven't had
a chance yet.

ping again?

ping again?

I will close this bug as NOTABUG if no response is received from the
reporter within ONE WEEK.

Sorry about the delay, I've been knee deep in other stuff for awhile.  I'll take
another look at this today.

Ok, I think this new spec and SRPM fix both the optflags problem and the locale
directory problem:

http://people.redhat.com/rnorwood/rpms/mathmap.spec
http://people.redhat.com/rnorwood/rpms/mathmap-1.2.4-3.fc9.src.rpm

Koji build against dist-f10:

http://koji.fedoraproject.org/koji/taskinfo?taskID=605186

Well, for 1.2.4-3:

* This package should have explicit "Requires: gimp" as
  - currently only gimp-libs is installed together by yum from library
    dependency
  - on the other hand $(gimptool --gimpdatadir) is owned by gimp,
    not by gimp-libs

Other things are okay.
-----------------------------------------------------------------------
       This package (mathmap) is APPROVED by me
-----------------------------------------------------------------------

ping?

Added the 'Requires: gimp':

http://people.redhat.com/rnorwood/rpms/mathmap.spec
http://people.redhat.com/rnorwood/rpms/mathmap-1.2.4-4.fc9.src.rpm

Since you've approved it with this change, here's the cvs request:

New Package CVS Request
=======================
Package Name: mathmap
Short Description: A gimp plugin and commandline tool
Owners: rnorwood
Branches: F-9
InitialCC: 
Cvsextras Commits: Yes

cvs done.

Please submit a F-9 updates request on bodhi. closing.

mathmap-1.2.4-4.fc9 has been submitted as an update for Fedora 9

mathmap-1.2.4-4.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.