Bug 431167
| Summary: | some imsettings code review | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthias Clasen <mclasen> |
| Component: | im-chooser | Assignee: | Akira TAGOH <tagoh> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 9 | CC: | eng-i18n-bugs |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-25 03:02:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Thank you for reviewing. The above things should be fixed in 0.99.1-1.fc9 except: (In reply to comment #0) > imsettings-manager.c: > > imsettings_manager_real_set_property: > > - no need to call g_object_notify inside a set_property implementation, > gobject does it for you. This also affects other set_property > implementations throughout the code. missed some cleanup for that. already fixed in svn though. so should appears in next release. > imsettings_manager_real_start_im: > > - I think it would be cleaner if imsettings_request_new would take a reference > on the connection, > and imsettings_manager_real_start_im would unref the connection afterwards. Actually the request is being sent through DBusGProxy and it increments the reference counter to keep the connection alive. so I don't think unref there would helps for something.. Instead I had unref outside IMSettingsRequest to free it. Should be improved in 0.99.2. Changing version to '9' as part of upcoming Fedora 9 GA. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping |
I decided to look over some of the imsettings code. I haven't gone over all of it, but here are some observations: imsettings-manager.c: imsettings_manager_real_set_property: - no need to call g_object_notify inside a set_property implementation, gobject does it for you. This also affects other set_property implementations throughout the code. - no need to protect g_free () with an if (foo != NULL), g_free is NULL-safe. imsettings_manager_real_get_list: - _("No input methods is available on your system.") - the "is" is extraneous. _start_process: - leaks env_list - argv = g_strsplit_set(cmd, " \t", -1) should probably use g_shell_parse_argv() ? - gchar *s = g_strdup_printf("%d", pid); write(fd, s, strlen(s)); leaks s _update_symlink: - there is at least one "goto end" between p = g_path_get_dirname(f); n = g_path_get_basename(f); and g_free(n); g_free(p); causing these strings to be leaked imsettings_manager_real_start_im: - I think it would be cleaner if imsettings_request_new would take a reference on the connection, and imsettings_manager_real_start_im would unref the connection afterwards. imsettings_manager_real_stop_im - There is at least one "goto end" between oinfo = imsettings_info_new(conffile); and if (oinfo) g_object_unref(oinfo); that will lead to leaking of oinfo