Bug 431188
| Summary: | Review Request: minbar - Athan call and prayer times notification software | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mohd Izhar Firdaus Ismail <mohd.izhar.firdaus> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mtasaka, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-03-02 17:16:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 431181 | ||
| Bug Blocks: | |||
|
Description
Mohd Izhar Firdaus Ismail
2008-02-01 12:48:41 UTC
Rebuild failed. http://koji.fedoraproject.org/koji/taskinfo?taskID=432105 Spec URL: http://izhar.fedorapeople.org/itl/minbar.spec SRPM URL: http://izhar.fedorapeople.org/itl/minbar-0.2.1-3.fc9.src.rpm fixed. - added missing BR perl(XML::Parser), desktop-file-utils For 0.2.1-3:
* Scriptlets
- Scriptlets for GConf are not right. (also scriptlets for %pre
is needed). Please check the subsection "GConf" of
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
- Also the scriptlets for GTK icon cache are not right.
Please check the same wiki page.
* Timestamp
- To keep timestamps on installed files, I recommend to use
---------------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
---------------------------------------------------------------
This method usually works for recent autotool-based Makefiles.
* Desktop file
- Why is the category 'Utility' listed twice?
* Documents
- Usually the file "INSTALL" is for people who want to build and install
softwares by themselves and is not needed for people using rpm system.
- Files under %_mandir are automatically marked as %doc.
* macros
- Please use macros correctly. For example /usr/bin must be %{_bindir}.
Updated http://izhar.fedorapeople.org/itl/minbar.spec http://izhar.fedorapeople.org/itl/minbar-0.2.1-4.fc9.src.rpm For 0.2.1-4:
* sed usage
-------------------------------------------------------
cat %{name}.desktop.in |sed "s|Utility;Utility;|Utility;|" > %{name}.desktop.tmp
mv %{name}.desktop.tmp %{name}.desktop.in
-------------------------------------------------------
- You can use -i (in place) option.
-------------------------------------------------------
sed -i -e "s|\(Utility;\)\1|\1|" %{name}.desktop.in
-------------------------------------------------------
* macros
- As I said in the previous comments, please replace all
/usr/bin with %{_bindir}.
-------------------------------------------------------
if [ -x /usr/bin/gtk-update-icon-cache ]; then
/usr/bin/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor
fi
-------------------------------------------------------
* scriptlet
- As I said in the previous comments the scriptlets for
GTK+ icon cache are not yet right. Please refer to
the section "GTK+ icon cache" of
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
again.
* Documents
- Files under %_mandir are automatically marked as %doc.
Thanks, I have updated the package - fixed gtk-update-icon-cache scriplet - changed sed to use -i - removed %doc from man files http://izhar.fedorapeople.org/itl/minbar.spec http://izhar.fedorapeople.org/itl/minbar-0.2.1-4.fc9.src.rpm For 0.2.1-5:
* GConf scriptlet
- I didn't notice before, but "Requires(pre): GConf" is
missing.
* sed usage
------------------------------------------------------------
sed -i "s|\(Utility;)\1|\1|" %{name}.desktop.in
------------------------------------------------------------
- The correct one is:
------------------------------------------------------------
sed -i "s|\(Utility;\)\1|\1|" %{name}.desktop.in
------------------------------------------------------------
Other things are okay.
--------------------------------------------------------------------------
This package (minbar) is APPROVED by me.
--------------------------------------------------------------------------
Thanks tasaka-san New Package CVS Request ======================= Package Name: minbar Short Description: Athan call and prayer times notification software Owners: izhar Branches: F-7 F-8 InitialCC: izhar Cvsextras Commits: yes cvs done. thanks all |