Bug 431310
| Summary: | Review Request: color-filesystem - Color filesystem layout | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicolas Chauvet (kwizart) <kwizart> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, pertusus, pknirsch |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-02-18 03:16:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 239936, 285351 | ||
|
Description
Nicolas Chauvet (kwizart)
2008-02-02 15:12:25 UTC
I don't know what BR gawk in kde-filesystem but I've kept it. The build dependency on gawk isn't needed at all; you might as well get rid of it. It's needed in the kde-filesystem package because that specfile actually calls awk. Packaging-wise, I see nothing wrong with this package. It only contains three directories (two empty) and one set of RPM macros, and macro usage, specfile naming, package naming, permissions, dependencies and directory ownership are all OK. On that I'm inclined to approve this. However, I wonder at the need to make a separate filesystem package for three directories, and the annoyance at needing something to provide color-filesystem forever once this gets in even if it turns out it's not a good idea. Has anyone talked to the maintainer of the filesystem package to see if these three directories could be added? The same goes for the rpm folks and the macros. I've tried to raise the problem on fedora-devel-list: https://www.redhat.com/archives/fedora-devel-list/2007-September/msg01875.html But I didn't get much answear. I thought the problem to include theses macros and directories to the filesystem package means directories to be part of the "Filesystem Hierarchy Standard", which they aren't until then. I guess that there are many directories in the filesystem package that are not in the FHS and, even if not, it is not an issue to add a set of common directories in -- if they really fit in. Any filesystem maintainer to gives advices ? Can i add this myself ? I guess anyone who has an opinion has had a chance to comment here or on the mailing list, and at this point I'd approve it if you drop the unnecessary gawk dependency. OK? Ok, let's introduce color-filesystem Can I remove gawk just before import? Yes, go ahead. APPROVED New Package CVS Request ======================= Package Name: color-filesystem Short Description: Color filesystem layout Owners: kwizart Branches: F-8 InitialCC: <empty> Commits by cvsextras: yes cvs done. thx for your review! |