Bug 431335
| Summary: | Review Request: decibel-audio-player - Music player for GNOME | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Debarshi Ray <debarshir> |
| Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | jpmahowald:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-05-25 18:59:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Debarshi Ray
2008-02-02 23:59:32 UTC
Does build and play on development.
However, it must install to %{python_sitelib} as per
http://fedoraproject.org/wiki/Packaging/Python
At the moment it's /usr/share/decibel-audio-player
Speaking of decibel-audio-player, why patch the .desktop to be Decibel Music
Player? Every other reference, from the package name to the about box is Decibel
Audio Player. I request it be Audio Player in the .desktop.
Why not use the default BuildRoot of
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) ?
Good:
Source matches
License of GPLv2+ matches source headers
(In reply to comment #1) > However, it must install to %{python_sitelib} as per > http://fedoraproject.org/wiki/Packaging/Python > At the moment it's /usr/share/decibel-audio-player Those Python files are only meant to be used by Decibel, and not any other program. Only system-wide files (or modules) should go in %{python_sitelib}, isn't it? > Speaking of decibel-audio-player, why patch the .desktop to be Decibel Music > Player? To ensure consistency in the desktop menus. We have "Banshee Music Player", "Exaile Music Player", etc.. So the trend seems to be "<name> Music Player" for such applications. What do you suggest? > Why not use the default BuildRoot of > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) ? That used to be the default BuildRoot. Not anymore. See: http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 This review is stalled. If there is no response from John Mahowald within a week, I will remove the FE-REVIEW blocker and replace it with FE-NEW. http://fedoraproject.org/wiki/PackageMaintainers/Policy/StalledReviews Good point regarding python files. They are arch independent so leave them in
%{_datadir}
I'll leave it to you to decide Music or Audio player, Music is fine. Both work
fine in English. The key word users will see is Decibel anyways.
Nice citation of the guidelines, that BuildRoot does meet the requirements.
So:
+ Still builds in development
+ Works
+ rpmlint is clean
+ Includes byte compiled files
+ License matches, GPLv2+
+ Proper Requires and BuildRequires
+ Installed .desktop file, appears under "Sound and Video"
+ Proper use of macros
APPROVED
New Package CVS Request ======================= Package Name: decibel-audio-player Short Description: Music player for GNOME Owners: rishi Branches: F-7 F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. |