Bug 431373
| Summary: | Review Request: incollector - Information collector | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Krzysztof Kurzawski <kurzawax> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-02-05 11:48:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Krzysztof Kurzawski
2008-02-03 19:49:12 UTC
build.log gave me
+ /usr/lib/rpm/find-lang.sh /var/tmp/incollector-1.0-1.fc9-root-mockbuild
incollector
No translations found for incollector in
/var/tmp/incollector-1.0-1.fc9-root-mockbuild
===> missing BR: gettext desktop-file-utils
any reason to exclude
%exclude %{_datadir}/locale/be-latin/LC_MESSAGES/incollector.mo
Source URL should be http://www.incollector.devnull.pl/download/sources/%{name}-%{version}.tar.gz Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/incollector/incollector.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/incollector/incollector-1.0-2.fc8.src.rpm I exclude %exclude %{_datadir}/locale/be-latin/LC_MESSAGES/incollector.mo because rpmlint warns: incollector.i386: E: incorrect-locale-subdir /usr/share/locale/be-latin/LC_MESSAGES/incollector.mo Thanks for review! I think you can try to use sed to replace be-latin.* to be@latin.* in build directory and also you need to have following %prep pushd po mv be-latin.po be mv be-latin.gmo be popd you just need to use following in %prep sed -i 's|be-latin|be@latin|' configure pushd po mv be-latin.po be mv be-latin.gmo be popd and this will solve your problem of rpmlint error. Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/incollector/incollector.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/incollector/incollector-1.0-3.fc8.src.rpm koji build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=394153 SHOULD: Not use macro for install command "%{__install} -p". Just use "install -p" Because you have not used macros for commands rm , make in spec. This worked for me ExclusiveArch: %ix86 x86_64 ppc Actually it should be ExclusiveArch: %ix86 x86_64 ppc ia64 armv4l sparc alpha ----from gtk-sharp2.spec Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/incollector/incollector.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/incollector/incollector-1.0-3.fc8.src.rpm Whooops I wrote bad link do SRPMS: SRPM URL: http://kurzawa.nonlogic.org/rpm/incollector/incollector-1.0-3.fc8.src.rpm Here is correct link: SRPM URL: http://kurzawa.nonlogic.org/rpm/incollector/incollector-1.0-4.fc8.src.rpm oops you add "----from gtk-sharp2.spec" remove this text Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/incollector/incollector.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/incollector/incollector-1.0-5.fc8.src.rpm Review: + package builds in mock (rawhide i386). koji build=>http://koji.fedoraproject.org/koji/taskinfo?taskID=394396 + rpmlint is silent for SRPM - rpmlint complains for RPM as incollector.i386: E: no-binary incollector.i386: E: only-non-binary-in-usr-lib But these can be ignored for mono packages. + source files match upstream. da510a279ebb5e8ebf9dbdcb2fc1cf18 incollector-1.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Desktop file handled correctly. + GUI app. APPROVED. New Package CVS Request ======================= Package Name: incollector Short Description: Information collector Owners: kurzawa Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes cvs done. Imported and built. Thanks again for review! |