Bug 431414
| Summary: | Review Request: planets - A celestial simulator | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gwyn Ciesla <gwync> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-02-06 18:24:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Gwyn Ciesla
2008-02-04 11:06:57 UTC
Drop unnecessary documentation files => BUGS INSTALL_w32.txt FILES BINFILES
INSTALL INSTALL.txt README.txt
use rpmmacros in %files for man file
/usr/share/man/man1/planets.1.gz
to
%{_mandir}/man1/planets.1.gz
koji build failed for ppc64 because of No Package Found for ocaml-camlp4-devel No Package Found for ocaml-labltk-devel on ppc64 koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=394314 You want to follow guidelines given at http://fedoraproject.org/wiki/Packaging/OCaml#head-d6d0bc21de370e51e9ca9bf5bc543224e2c668d4 Hmm, looks like ExcludeArch: ppc64 might be in order. Concur? As this package uses ocaml, I think good to follow same what ocaml used in SPEC =>
ExclusiveArch: alpha armv4l %{ix86} ia64 x86_64 ppc sparc
Agreed. All of the above addressed, see original URLs. NVR not incremented. (In reply to comment #5) > Agreed. All of the above addressed, see original URLs. NVR not incremented. which you should have done actually..... That will help to differentiate between exiting SRPM I have downloaded and new one to review it without confusion. Also, Changelog will suggest how review got progressed with written changes in changelog. Fixed: Spec URL: http://zanoni.jcomserv.net/fedora/planets/planets.spec SRPM URL: http://zanoni.jcomserv.net/fedora/planets/planets-0.1.13-2.fc8.src.rpm Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=398193 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 2c72f2469ee0413bd470a2ad84f2f0f8 planets-0.1.13.tgz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Desktop file installed correctly + GUI app. APPROVED. oops missed to modify my review template for scriptlet + gtk-update-icon-cache scriptlets are used. Thanks for the review! New Package CVS Request ======================= Package Name: planets Short Description: A celestial simulator Owners: limb Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes cvs done. Imported and built. Thanks all! Package Change Request ====================== Package Name: planets New Branches: EL-6 Owners: limb CVS done (by process-cvs-requests.py). Thanks! |