Bug 431452

Summary:	Wrong init script
Product:	[Fedora] Fedora	Reporter:	Martin Nagy <mnagy>
Component:	vsftpd	Assignee:	Martin Nagy <mnagy>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	low
Version:	rawhide	CC:	hripps, mnagy
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-02-25 16:55:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Martin Nagy 2008-02-04 16:15:38 UTC

+++ This bug was initially created as a clone of Bug #431450 +++

Description of problem:
In several occasions, the script may end with return code 0 even when the
service does not start correctly. For example

[ -x /usr/sbin/vsftpd ] || exit 0

Version-Release number of selected component (if applicable):
all

How reproducible:
always

Steps to Reproduce:
1. change access rights such that /usr/sbin/vsftpd is not executable
2. service vsftpd start
3. echo $?
  
Actual results:
0

Expected results:
Non-zero exit code with respect to our guidelines.

Additional info:
When fixing this bug, please obbey our init script guidelines and be sure that
status command is run correctly.
Our guidelines are on following two pages:
http://intranet.corp.redhat.com/ic/intranet/InitscriptsSpec.html
http://intranet.corp.redhat.com/ic/intranet/InitscriptGuidelines.html

For an example of the script that returns the error codes correctly and always
runs status see:
http://devserv.devel.redhat.com/~mmarcini/amd

Comment 1 Martin Nagy 2008-02-25 16:55:34 UTC

Fixed in vsftpd-2.0.6-2.fc9