Bug 431672

Summary:	Review Request: scythia - Just a small ftp client
Product:	[Fedora] Fedora	Reporter:	Krzysztof Kurzawski <kurzawax>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-02-08 14:17:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Krzysztof Kurzawski 2008-02-06 11:46:04 UTC

Spec URL: http://kurzawa.nonlogic.org/rpm/scythia/scythia.spec
SRPM URL: http://kurzawa.nonlogic.org/rpm/scythia/scythia-0.9.3-2.1.fc8.src.rpm
Description: Scythia project is an simple and portable Ftp client. It does not claim to be
able to replace the biggest (no SSH etc.), but only to satisfy some persons
and to give us a bigger experience in programming.

Comment 1 Parag AN(पराग) 2008-02-06 12:36:56 UTC

1)license is GPLv3+
2)can it be possible to add GenericName and comment for french also in .desktop
like you did for pl_PL

Comment 2 Krzysztof Kurzawski 2008-02-06 13:06:31 UTC

Fixed
Spec URL: http://kurzawa.nonlogic.org/rpm/scythia/scythia.spec
SRPM URL: http://kurzawa.nonlogic.org/rpm/scythia/scythia-0.9.3-2.2.fc8.src.rpm

Thanks for review!

Comment 3 Parag AN(पराग) 2008-02-07 06:24:16 UTC

Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=400409
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
2286269b90c84f52463580a271f608b5  scythia_0.9.3-2-src.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honored correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ gtk-update-icon-cache scriptlets are used.
+ Desktop file installed correctly.
+ GUI app.

APPROVED.

Comment 4 Krzysztof Kurzawski 2008-02-07 09:27:30 UTC

New Package CVS Request
=======================
Package Name: scythia
Short Description: Just a small ftp client
Owners: kurzawa
Branches: F-7 F-8
InitialCC:
Cvsextras Commits: yes

Comment 5 Kevin Fenzi 2008-02-07 17:19:15 UTC

cvs done.

Comment 6 Krzysztof Kurzawski 2008-02-08 14:17:56 UTC

Imported and built. Thanks again for review!