Bug 431683
| Summary: | Review Request: evolution-rspam - Evolution Plugin for reporting spam | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lucian Langa <lucilanga> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, mbarnes, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-07-15 17:22:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Lucian Langa
2008-02-06 13:55:06 UTC
Please use the following URLs instead Spec URL: http://gnome.eu.org/rspam.spec SRPM URL: http://gnome.eu.org/rspam-0.0.6-1.fc8.src.rpm sorry for the inconvenience. This is an unofficial review, I can't approve your package or sponsor you. [+] rpmlint is silent [+] the package build in mock [-] don't use %define for name, version and release [-] the URL:http://mips.edu.ms/evo/index.php/Report_as_Spam doesn't seem to be related with this program. [-] the recommended value for the BuildRoot is %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) > This is an unofficial review, I can't approve your package or sponsor you. Thanks for help. > [-] don't use %define for name, version and release fixed > [-] the URL:http://mips.edu.ms/evo/index.php/Report_as_Spam doesn't seem to be > related with this program. updated to the new url > [-] the recommended value for the BuildRoot > is %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) fixed Ok, to me the package seems good.
If you like you can use:
find %{buildroot} -name \*\.la -delete
instead of:
find %{buildroot} -name \*\.la -print | xargs rm -f
Removing NEEDSPONSOR (bug 430070) Adding mbarnes (evolution maintainer) to CC I don't know if we have any guidelines here, but it seems to me that it might be good for Fedora packages containing evolution plugins to have a "evolution-" or "evolution-plugin-" prefix or somesuch. Not sure if it's worth overriding the upstream name in this way. Have any other out-of-tree evolution plugins been packaged for Fedora yet? (In reply to comment #6) > Have any other out-of-tree evolution plugins been > packaged for Fedora yet? yes, my other plugin evolution-rss. Just for clarity I think I'd prefer "evolution-rspam" as the package name. changed name and bumped version: new files: http://lucilanga.fedorapeople.org/evolution-rspam.spec http://lucilanga.fedorapeople.org/evolution-rspam-0.0.6-2.fc9.src.rpm * Please consider to use
make install DESTDIR=%{buildroot} DESTDIR="install -p"
to keep timestamps on installed files
* Calling /sbin/ldconfig on scriptlets is not needed for this package, as no
libraries
are installed under default ld search paths.
Other things seem okay.
Hello Mamoru, thanks for doing this I've incorporated the modification and bump version. new files: http://lucilanga.fedorapeople.org/evolution-rspam.spec http://lucilanga.fedorapeople.org/evolution-rspam-0.0.6-3.fc9.src.rpm Okay.
----------------------------------------------------------------------------
This package (evolution-rspam) is APPROVED by me
----------------------------------------------------------------------------
New Package CVS Request ======================= Package Name: evolution-rspam Short Description: Evolution Plugin for reporting spam Owners: lucilanga Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. evolution-rspam-0.0.6-3.fc9 has been submitted as an update for Fedora 9 evolution-rspam-0.0.6-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |