Bug 431943

Summary: FPE exception for hugemem vmcores (p2)
Product: Red Hat Enterprise Linux 4 Reporter: Andrew Hecox <ahecox>
Component: diskdumputilsAssignee: Linda Wang <lwang>
Status: CLOSED DUPLICATE QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: 4.8CC: anderson, tindoh
Target Milestone: rc   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-02-12 22:03:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
validate log_buf_len none

Description Andrew Hecox 2008-02-07 22:43:40 UTC 
related to:

https://bugzilla.redhat.com/show_bug.cgi?id=431937

in get_logbuf, diskdumpmsg does not check for a non-zero value of log_buf_len
before using it as a divisor. In cases where
read_int->read_buffer_sym->read_buffer cannot read the appropriate page,
log_buf_len is set to zero. On return, this causes a divide by zero exception.

This patch is one way of reporting an error without the FPE.

The patch in 431937 fixes the only case I know of where this actually happens;
accordingly, this patch is mostly cosmetic.
Comment 1 Andrew Hecox 2008-02-07 22:43:40 UTC 
Created attachment 294281 [details]
validate log_buf_len
Comment 2 Dave Anderson 2008-02-08 13:59:54 UTC 
I'm not sure why this can't be combined with BZ #431937, but in any case,
can this be a RHEL4.7 errata candidate?
Comment 3 RHEL Program Management 2008-02-08 14:08:09 UTC 
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.
Comment 4 Andrew Hecox 2008-02-12 21:38:16 UTC 
Dave -- would you like me to close this issue and just deal with it via the
related bz?
Comment 5 Dave Anderson 2008-02-12 21:42:34 UTC 
I think it makes more sense to do it that way -- but append your log_buf_len
patch above to the other bugzilla so that it doesn't get lost.
Comment 6 Andrew Hecox 2008-02-12 22:03:04 UTC 
closing, should be covered in https://bugzilla.redhat.com/show_bug.cgi?id=431937.

*** This bug has been marked as a duplicate of 431937 ***