Bug 431976
| Summary: | Review Request: yoltia - Qt based picture editing program | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Krzysztof Kurzawski <kurzawax> | ||||
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review, notting | ||||
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
dennis: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-02-09 09:57:38 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Krzysztof Kurzawski
2008-02-08 07:06:34 UTC
koji build failed for me http://koji.fedoraproject.org/koji/taskinfo?taskID=402634 But when I tried build this package in koji it was ok. http://koji.fedoraproject.org/koji/taskinfo?taskID=402731 What should I do? Krzysztof: you've tested only on F8, but the preferred testing target is rawhide. Created attachment 294329 [details]
suggested patch to compile yoltia with gcc43
Please try this patch.
Hey mtasaka, Thanks for this patch. I just used that and this package built successfully on my rawhide machine now. I was actually figuring out how to solve problem in qt packages but looked like it is gcc issue from patch name. Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/yoltia/yoltia.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/yoltia/yoltia-0.22.1-2.fc8.src.rpm Thanks for review and thanks for patch! Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=402818 + rpmlint is silent for SRPM and for RPM. + source files match upstream. ae49da3e9f22569d81b278a1e0eb7b42 yoltia-0.22.1.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Desktop file installed correctly. + GUI app. APPROVED. New Package CVS Request ======================= Package Name: yoltia Short Description: Qt based picture editing program Owners: kurzawa Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes CVS Done Imported and built. Thanks again fo review! |