Bug 432580

Summary:	Review Request: ffsb - The Flexible Filesystem Benchmark
Product:	[Fedora] Fedora	Reporter:	Eric Sandeen <esandeen>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-02-15 05:47:11 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Eric Sandeen 2008-02-13 02:47:21 UTC

Spec URL: http://sandeen.fedorapeople.org/ffsb/ffsb.spec
SRPM URL: http://sandeen.fedorapeople.org/ffsb/ffsb-5.2.1-1.fc8.src.rpm
Description: 
The Flexible Filesystem Benchmark (FFSB) is a cross-platform filesystem
performance measurement tool. It uses customizable profiles to measure
of different workloads, and it supports multiple groups of threads
across multiple filesystems.

Comment 1 Parag AN(पराग) 2008-02-13 03:38:30 UTC

+ is OK
- is Need work

Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=421570
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
b58c515d990886cab69b7d9b726536cd  ffsb-5.2.1.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honored correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
- Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

SHOULD:
  1)Use macros in %files section also. use %{_bindir}
  2)you can use defattr as defattr(-,root,root,-)

I am waiting for koji build to finish to see it builds on all archs.

Comment 2 Parag AN(पराग) 2008-02-13 03:39:31 UTC

oops. I changed flag to fedora-review+ before koji build finishes.

Comment 3 Eric Sandeen 2008-02-13 03:59:29 UTC

>  1)Use macros in %files section also. use %{_bindir}

oops meant to; quickly put in /usr/bin/ because I couldn't remember the macro
name :)

Will fix those up.

Thanks!
-Eric

Comment 4 Eric Sandeen 2008-02-13 04:02:21 UTC

updated files posted at same urls.

Comment 5 Eric Sandeen 2008-02-13 04:18:57 UTC

Koji was sad but now building:
http://koji.fedoraproject.org/koji/taskinfo?taskID=421883

Comment 6 Parag AN(पराग) 2008-02-13 04:59:00 UTC

thanks for the build

APPROVED.

Comment 7 Eric Sandeen 2008-02-13 05:06:23 UTC

Thanks for the quick review!

New Package CVS Request
=======================
Package Name: ffsb
Short Description: The Flexible Filesystem Benchmark
Owners: sandeen
Branches: F-8
InitialCC: 
Cvsextras Commits: yes

Comment 8 Kevin Fenzi 2008-02-13 17:38:39 UTC

cvs done.

Comment 9 Eric Sandeen 2008-02-15 05:47:11 UTC

All set, thanks!