Bug 432741
| Summary: | Review Request: sarai-fonts - Free Sarai Hindi Truetype Font | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rahul Sundaram <sundaram> |
| Component: | Package Review | Assignee: | Rahul Bhalerao <b.rahul.pm> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eng-i18n-bugs, fedora-package-review, kevin, notting, pnemade, smohan |
| Target Milestone: | --- | Flags: | b.rahul.pm:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-02-23 14:51:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Rahul Sundaram
2008-02-14 03:53:45 UTC
Output of rpmlint:
$ rpmlint sarai-fonts-1.0-1.fc8.noarch.rpm
sarai-fonts.noarch: W: no-documentation
The above may be ignored, but it is recommended to include a license text file
as a part of documentation.
You may use %{fontname} in following line:
4 Name: sarai-fonts
I think URL should be the one from sarai.net.
http://www.sarai.net/practices/indic-localization/downloads-1/Sarai_07.ttf
According to new policies, please replace $RPM_BUILD_ROOT with %{buildroot}.
Rest all looks fine.
New revision: http://sundaram.fedorapeople.org/packages/sarai-fonts.spec http://sundaram.fedorapeople.org/packages/sarai-fonts-1.0-2.fc8.src.rpm Fixed URL Used macro as suggested Added License I checked the policies and didn't see one enforcing a particular style of buildroot. The packaging guidelines suggests the package maintainer pick one and stick to it which is what I am doing now. Output of rpmlint: "sarai-fonts.noarch: E: description-line-too-long This package provides a free Sarai Hindi TrueType font. It is meant for print and publishing needs." There should be a line break every 80 characters. The URL given for Source0 is not a direct link to the font file. It gives another webpage. I would suggest to keep the earlier source, i.e. just "Sarai_07.ttf". New revision http://sundaram.fedorapeople.org/packages/sarai-fonts.spec http://sundaram.fedorapeople.org/packages/sarai-fonts-1.0-3.fc8.src.rpm Fixed the two issues pointed out. Thanks. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url b5f792b2fb76b7448c96f6a8f77b1390 Sarai_07.ttf + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + font is open source-compatible. + License text is included in package. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + fonts scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI App. APPROVED Thanks for the review. New Package CVS Request ======================= Package Name: sarai-fonts Short Description: Owners: sundaram,pnemade Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes Is there no Short Description here? Should it be "Free Sarai Hindi Truetype Font" ? Yes. Sorry I missed that. cvs done. is this built? Build now. 1. Please update the Fedora comps file (Cf grouping section of http://fedoraproject.org/wiki/Packaging/FontsPolicy) 2. Please add this package to the "Packaged fonts" list at http://fedoraproject.org/wiki/SIGs/Fonts/Triaging/Pipeline |