Bug 432817
| Summary: | Review Request: greyhounds - Greyhounds is a greyhounds racing and breeding game | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Krzysztof Kurzawski <kurzawax> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-03-15 16:35:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Krzysztof Kurzawski
2008-02-14 16:20:42 UTC
As the owner of 4 greyhounds, I would be happy to review this package... ;) Look for a full review later tonight. OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. See below - Meets Packaging Guidelines. See below - License See below - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 57dd2731e05de80b04077e5e2396b1a8 greyhounds-0.8-pre-alpha.tar.bz2 57dd2731e05de80b04077e5e2396b1a8 greyhounds-0.8-pre-alpha.tar.bz2.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. Not that it matters much, but upstream uses 'pre-alpha' instead of 'prealpha' 2. Can you ask upstream to clarify the license? The README file has "The game is GPL-licensed." None of the source files contain any licensing information. That would seem to imply "GPL+" (ie, any version of the GPL). 3. Oddly, the Source0 url should probibly be: http://downloads.sourceforge.net/byghound/%{name}-%{version}-pre-alpha.tar.bz2 Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/greyhounds/greyhounds.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/greyhounds/greyhounds-0.8-0.2.prealpha.fc8.src.rpm If I set release "0.1.pre-alpha%{?dist}" rpmbuild warns: error: line 3: Illegal char '-' in release: Release: 0.1.pre-alpha.fc8 so what should I do? Upstream said that license is GPLv2. Spec URL: http://kurzawa.nonlogic.org/rpm/greyhounds/greyhounds.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/greyhounds/greyhounds-0.8-0.3.prealpha.fc8.src.rpm The package from comment #4 looks all good to me... This package is APPROVED. Just out of curiosity, is upstream planning further development? The upstream source seems to have last been updated in 2003. ;( New Package CVS Request ======================= Package Name: greyhounds Short Description: Greyhounds is a greyhounds racing and breeding game Owners: kurzawa Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes Thanks for review! cvs done. This package has been built and imported from what I can see... closing this review now. |