Bug 432921

Summary:	Review Request: fldigi - Digital modem program for Linux.
Product:	[Fedora] Fedora	Reporter:	Robert 'Bob' Jensen <bob>
Component:	Package Review	Assignee:	Jeroen van Meeuwen <vanmeeuwen+fedora>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, hobbes1069, mtasaka, notting, sconklin, vanmeeuwen+fedora
Target Milestone:	---	Flags:	vanmeeuwen+fedora: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	2.09-3.fc8	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-02-19 03:18:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Robert 'Bob' Jensen 2008-02-15 06:48:08 UTC

Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/fldigi.spec
SRPM URL: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/fldigi-2.09-2.fc8.src.rpm
Description: fldigi is a modem program which supports most of the digital modes used by hamradio operators today. You can also use the program for calibrating your sound card to WWV or doing a frequency measurement test. The program also comes with a CW decoder. fldigi is written with the help of the Fast Light Toolkit X GUI.

Package builds against rawhide, is waiting for https://admin.fedoraproject.org/updates/F8/FEDORA-2008-1308 so it can be built for F8.

Comment 1 Jeroen van Meeuwen 2008-02-16 00:35:35 UTC

RPM Lint: OK
Package name: OK
Spec file: OK
License: OK
Actual License: GPLv2+ (from source)
%doc License: N/A
Spec file language: English
Spec file readable: OK
Upstream source vs. used tarball: OK (md5sum match)
Compile and Build:
 - F7 FAILED (not targeted),
 - F8 OK,
 - rawhide OK,
 - EL5 FAILED (not targeted)

Applicable Package Guidelines:
 - -debuginfo package: OK
 - .desktop file: Upstream Make (Automake) does not call desktop-file-install

Locales: N/A
Shared libs: N/A
Relocatable: N/A
Directory and file ownership: OK
No duplicate files in %files: OK
File Permissions: OK
Macro usage: OK
Code vs. Content: OK
(Large) Documentation: N/A
%doc affecting runtime: OK
Header files in -devel package: N/A
Static Libraries in -static package: N/A
pkgconfig Requires: N/A
Library files: N/A
Devel requires base package: N/A
.la libtool archives: N/A
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK

APPROVED

Comment 2 Jeroen van Meeuwen 2008-02-16 00:37:52 UTC

Mark as Review done

Comment 3 Robert 'Bob' Jensen 2008-02-16 00:45:34 UTC

New Package CVS Request
=======================
Package Name: fldigi
Short Description: Digital modem program for Linux
Owners: bjensen,sconklin
Branches: F-8
InitialCC: sindrebp
Cvsextras Commits: Yes

Comment 4 Kevin Fenzi 2008-02-16 03:28:24 UTC

cvs done.

Comment 5 Mamoru TASAKA 2008-02-16 04:05:33 UTC

- When installing desktop files, desktop-file-install must be called
  ("desktop-file-install usage" of
    http://fedoraproject.org/wiki/Packaging/Guidelines )

Comment 6 Robert 'Bob' Jensen 2008-02-16 16:03:14 UTC

(In reply to comment #5)
> - When installing desktop files, desktop-file-install must be called
>   ("desktop-file-install usage" of
>     http://fedoraproject.org/wiki/Packaging/Guidelines )

I will review this and make the change before the next build.

Thank you for looking.

Comment 7 Fedora Update System 2008-02-16 21:38:51 UTC

fldigi-2.09-3.fc8 has been submitted as an update for Fedora 8

Comment 8 Steve Conklin 2008-02-16 21:39:32 UTC

Change made. Tagged, built for devel and F-8, and pushed to F-8.

Thanks!

Comment 9 Robert 'Bob' Jensen 2008-02-16 23:44:13 UTC

Thank you Steve, Mamoru, Jeroen and Kevin

Comment 10 Fedora Update System 2008-02-19 03:18:37 UTC

fldigi-2.09-3.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Richard Shaw 2013-08-27 12:59:58 UTC

Package Change Request
======================
Package Name: fldigi
New Branches: el6
Owners: hobbes1069
InitialCC:

Comment 12 Gwyn Ciesla 2013-08-27 13:37:54 UTC

Git done (by process-git-requests).

Comment 13 Richard Shaw 2014-06-09 15:08:48 UTC

Package Change Request
======================
Package Name: fldigi
New Branches: epel7
Owners: hobbes1069
InitialCC:

Comment 14 Gwyn Ciesla 2014-06-09 19:14:16 UTC

Git done (by process-git-requests).