Bug 432971
| Summary: | Review Request: python-turboflot - A TurboGears widget for Flot, a jQuery plotting library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Luke Macken <lmacken> |
| Component: | Package Review | Assignee: | Jan ONDREJ <ondrejj> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, pfrields |
| Target Milestone: | --- | Flags: | ondrejj:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-02-19 04:58:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Luke Macken
2008-02-15 14:56:46 UTC
rpmlint output: python-turboflot.noarch: W: incoherent-version-in-changelog 0.0.4-1 0.0.5-1.fc8 I think this package requires TurboGears and simplejson, so add: Requires: TurboGears >= 1.0.3, python-simplejson >= ... or something similar. Source package do not match upstream and source URL is not complete! May be there is a missing "." at end of description (just summary can't end with "."). Package do not build in mock, add for example this:
BuildRequires: python-setuptools >= 0.6c5
Error output:
+ /usr/bin/python setup.py build
Traceback (most recent call last):
File "setup.py", line 2, in <module>
from setuptools import setup, find_packages
ImportError: No module named setuptools
error: Bad exit status from /var/tmp/rpm-tmp.21399 (%build)
http://hg.lewk.org/TurboFlot/raw-file/836ad97edcc8/python-turboflot.spec http://pypi.python.org/packages/2.5/T/TurboFlot/python-turboflot-0.0.5-2.fc8.src.rpm * Sat Feb 16 2008 Luke Macken <lmacken> - 0.0.5-2 - Add TurboGears to BuildRequires and Requires - Require python-simplejson - Fix description - Fix Source0 Source URL still do not match upstream!
- MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
- It is nicer to use %{version} in Source URL. It is not required, so you can
leave it as is is you wish.
If you fix source, I can approve this package.
http://hg.lewk.org/TurboFlot/raw-file/9fb8a0f1bb73/python-turboflot.spec http://pypi.python.org/packages/any/T/TurboFlot/python-turboflot-0.0.5-2.fc8.src.rpm I recreated the rpm with the upstream sources listed in Source0. I also now use %{version} in the Source0, and have modified the URL to point to the Python Package Index, instead of my blog. Much better. :-) APPROVED. Thanks for taking the time out to review, Jan :) New Package CVS Request ======================= Package Name: python-turboflot Short Description: A TurboGears widget for Flot, a jQuery plotting library Owners: lmacken Branches: F-8 F-7 EL-5 Cvsextras Commits: Yes cvs done. Updates queued for F7/F8. Thanks! |