Bugzilla (bugzilla.redhat.com) will be under maintenance for infrastructure upgrades and will not be available on July 31st between 12:30 AM - 05:30 AM UTC. We appreciate your understanding and patience. You can follow status.redhat.com for details.

Bug 433082

Summary: Review Request: libax24 - AX.25 library for hamradio applications
Product: [Fedora] Fedora Reporter: Robert 'Bob' Jensen <bob>
Component: Package ReviewAssignee: Jeroen van Meeuwen <vanmeeuwen+fedora>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, mtasaka, notting
Target Milestone: ---Flags: vanmeeuwen+fedora: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-02-28 21:37:28 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Robert 'Bob' Jensen 2008-02-16 01:15:48 UTC
Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/libax25.spec
SRPM URL: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/libax25-0.0.11-2.fc8.src.rpm
Description: libax25 is a library for ham radio applications that use the ax25 protocol. Included are routines to do ax25 address parsing, common ax25 application config file parsing, etc

Comment 1 Jeroen van Meeuwen 2008-02-16 01:45:22 UTC
RPM Lint: OK
Package name: OK
Spec file: OK
License: OK
Actual License: LPGLv2+ (from source files: `grep -rin -A 2 lesser *` inside the
source tree shows, COPYING has LGPLv2.1)
%doc License: OK
Spec file language: OK
Spec file readable: OK
Upstream source vs. used tarball: OK (md5sum match)
Compile and Build:
 - F7 OK
 - F8 OK
 - rawhide OK
 - EL5 OK

Applicable Package Guidelines:
 - -debuginfo package: OK (~49K)
 - -devel package: FAILED (see below)

Locales: N/A
Shared libs: OK
Relocatable: N/A
Directory and file ownership: OK
No duplicate files in %files: OK
File Permissions: OK
Macro usage: OK
Code vs. Content: OK
(Large) Documentation: N/A
%doc affecting runtime: OK
Header files in -devel package: FAILED (see below)
Static Libraries in -static package: N/A
pkgconfig Requires: N/A
Library files: OK
Devel requires base package: OK
.la libtool archives: N/A
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK


Below shows that the base package lacks a couple of files (man pages for
example), whereas the -devel package picks them up.

[jmeeuwen@unity05 fedora-ham]$ rpm -qlp
[jmeeuwen@unity05 fedora-ham]$ rpm -qlp


Replace the %files sections in the .spec with: (and things should be OK)


%files devel

Comment 3 Jeroen van Meeuwen 2008-02-16 02:07:59 UTC
Issues confirmed fixed, builds OK and files end up in the right package.


Comment 4 Robert 'Bob' Jensen 2008-02-16 02:11:14 UTC
New Package CVS Request
Package Name: libax25
Short Description: AX.25 library for hamradio applications
Owners: bjensen,sconklin
Branches: F-7 F-8
InitialCC: sindrebp
Cvsextras Commits: Yes

Comment 5 Kevin Fenzi 2008-02-16 03:37:02 UTC
cvs done.

Comment 6 Mamoru TASAKA 2008-02-16 04:03:05 UTC
Usually section 3 man files are for the explanation of functions
and should be in -devel subpackage.

Comment 7 Robert 'Bob' Jensen 2008-02-16 16:02:46 UTC
(In reply to comment #6)
> Usually section 3 man files are for the explanation of functions
> and should be in -devel subpackage.

I will review this and make the change before the next build.

Comment 8 Fedora Update System 2008-02-17 00:42:07 UTC
unixcw-2.3-2.fc7 has been submitted as an update for Fedora 7

Comment 9 Fedora Update System 2008-02-17 00:47:52 UTC
libax25-0.0.11-3.fc8 has been submitted as an update for Fedora 8

Comment 10 Fedora Update System 2008-02-19 03:14:52 UTC
libax25-0.0.11-3.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2008-02-19 03:14:57 UTC
libax25-0.0.11-3.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Jeroen van Meeuwen 2008-02-28 21:37:28 UTC