Bug 433082
| Summary: | Review Request: libax24 - AX.25 library for hamradio applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert 'Bob' Jensen <bob> |
| Component: | Package Review | Assignee: | Jeroen van Meeuwen <vanmeeuwen+fedora> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mtasaka, notting |
| Target Milestone: | --- | Flags: | vanmeeuwen+fedora:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-02-28 21:37:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Robert 'Bob' Jensen
2008-02-16 01:15:48 UTC
RPM Lint: OK
Package name: OK
Spec file: OK
License: OK
Actual License: LPGLv2+ (from source files: `grep -rin -A 2 lesser *` inside the
source tree shows, COPYING has LGPLv2.1)
%doc License: OK
Spec file language: OK
Spec file readable: OK
Upstream source vs. used tarball: OK (md5sum match)
Compile and Build:
- F7 OK
- F8 OK
- rawhide OK
- EL5 OK
Applicable Package Guidelines:
- -debuginfo package: OK (~49K)
- -devel package: FAILED (see below)
Locales: N/A
Shared libs: OK
Relocatable: N/A
Directory and file ownership: OK
No duplicate files in %files: OK
File Permissions: OK
Macro usage: OK
Code vs. Content: OK
(Large) Documentation: N/A
%doc affecting runtime: OK
Header files in -devel package: FAILED (see below)
Static Libraries in -static package: N/A
pkgconfig Requires: N/A
Library files: OK
Devel requires base package: OK
.la libtool archives: N/A
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK
==
Below shows that the base package lacks a couple of files (man pages for
example), whereas the -devel package picks them up.
[jmeeuwen@unity05 fedora-ham]$ rpm -qlp
/var/lib/mock/fedora-8-i386/result/libax25-devel-0.0.11-2.fc8.i386.rpm
/usr/include/netax25
/usr/include/netax25/ax25io.h
/usr/include/netax25/axconfig.h
/usr/include/netax25/axlib.h
/usr/include/netax25/daemon.h
/usr/include/netax25/kernel_ax25.h
/usr/include/netax25/kernel_netrom.h
/usr/include/netax25/kernel_rose.h
/usr/include/netax25/mheard.h
/usr/include/netax25/nrconfig.h
/usr/include/netax25/procutils.h
/usr/include/netax25/rsconfig.h
/usr/include/netax25/ttyutils.h
/usr/lib/libax25.so
/usr/lib/libax25io.so
/usr/share/doc/libax25-devel-0.0.11
/usr/share/doc/libax25-devel-0.0.11/AUTHORS
/usr/share/doc/libax25-devel-0.0.11/COPYING
/usr/share/doc/libax25-devel-0.0.11/ChangeLog
/usr/share/doc/libax25-devel-0.0.11/README
/usr/share/man/man3/ax25.3.gz
/usr/share/man/man3/rose.3.gz
/usr/share/man/man5/axports.5.gz
/usr/share/man/man5/nrports.5.gz
/usr/share/man/man5/rsports.5.gz
[jmeeuwen@unity05 fedora-ham]$ rpm -qlp
/var/lib/mock/fedora-8-i386/result/libax25-0.0.11-2.fc8.i386.rpm
/usr/lib/libax25.so.0
/usr/lib/libax25.so.0.0.0
/usr/lib/libax25io.so.0
/usr/lib/libax25io.so.0.0.0
/usr/share/doc/libax25-0.0.11
/usr/share/doc/libax25-0.0.11/COPYING
/usr/share/doc/libax25-0.0.11/README
==
Replace the %files sections in the .spec with: (and things should be OK)
%files
%defattr(-,root,root,-)
%doc AUTHORS ChangeLog COPYING README
%{_libdir}/*.so.*
%{_mandir}/man?/*
%files devel
%defattr(-,root,root,-)
%{_includedir}/*
%{_libdir}/*.so
updated Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/libax25.spec SRPM URL: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/libax25-0.0.11-3.fc8.src.rpm Issues confirmed fixed, builds OK and files end up in the right package. APPROVED New Package CVS Request ======================= Package Name: libax25 Short Description: AX.25 library for hamradio applications Owners: bjensen,sconklin Branches: F-7 F-8 InitialCC: sindrebp Cvsextras Commits: Yes cvs done. Usually section 3 man files are for the explanation of functions and should be in -devel subpackage. (In reply to comment #6) > Usually section 3 man files are for the explanation of functions > and should be in -devel subpackage. I will review this and make the change before the next build. unixcw-2.3-2.fc7 has been submitted as an update for Fedora 7 libax25-0.0.11-3.fc8 has been submitted as an update for Fedora 8 libax25-0.0.11-3.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. libax25-0.0.11-3.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. Closing |