Bug 433219

Updated ...

Spec URL:  
http://downloads.sourceforge.net/anyremote/ganyremote-fedora.spec?use_mirror=osdn

SRPM URL: 
http://downloads.sourceforge.net/anyremote/ganyremote-2.6-3.fc8.src.rpm?use_mirror=osdn

Updated ...

Spec URL: 
http://downloads.sourceforge.net/anyremote/ganyremote.spec?use_mirror=osdn

SRPM URL:
http://downloads.sourceforge.net/anyremote/ganyremote-2.7-1.fc8.src.rpm?use_mirror=osdn

(Removing NEEDSPONSOR: bug 433135)

Is anyone interested in making code review ?

For 2.7-1:
* Spec file name
  - Spec file name must be ganyremote.spec .

* Requires
  - "pygtk2" has "Requires: python(abi) = 2.5" and
    "Requires: python >= 2.4" is not needed and should be removed.

  - /usr/bin/ganyremote has some extra dependency such as
-----------------------------------------------------------------
   222          ret = getResult('hcitool name '+data,'browser')
   250          elif (isInstalled('bluetooth-sendto') == 'OK'):
   251              sender = 'bluetooth-sendto --dest='
.....
-----------------------------------------------------------------
    Apparently ganyremote should have "Requires: bluez-utils"

* autotool call
  - build.log shows:
-----------------------------------------------------------------
    62  Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.30585
    63  + umask 022
    64  + cd /builddir/build/BUILD
    65  + cd ganyremote-2.7
    66  + LANG=C
    67  + export LANG
    68  + unset DISPLAY
    69  + rm -rf /var/tmp/ganyremote-2.7-1.fc9-root-mockbuild
    70  + make DESTDIR=/var/tmp/ganyremote-2.7-1.fc9-root-mockbuild install
    71  cd . && /bin/sh /builddir/build/BUILD/ganyremote-2.7/missing --run
aclocal-1.10 
    72  /builddir/build/BUILD/ganyremote-2.7/missing: line 54: aclocal-1.10:
command not found
    73  WARNING: `aclocal-1.10' is missing on your system.  You should only need
it if
    74           you modified `acinclude.m4' or `configure.in'.  You might want
    75           to install the `Automake' and `Perl' packages.  Grab them from
    76           any GNU archive site.
    77   cd . && /bin/sh /builddir/build/BUILD/ganyremote-2.7/missing --run
automake-1.10 --gnu 
-----------------------------------------------------------------
    Here autotools are called automatically, which is unwilling because
    this may change configure, makefiles in unwilling ways.
    This usually means that the timestamps of related files (i.e.
    configure{,in} etc) are wrong and this can usually be fixed
    by "touch"ing those files.

* desktop file directory
  - Don't install desktop files under other than %{_datadir}/applications

* desktop file Category
  - If you want that the group of this rpm should be "Applications/System",
    then the installed desktop file should have "System" category.

* Directory structure
  - Please move documents to under %_defaultdocdir (preferably 
    %_defaultdocdir/%name-%version, modification for %_bindir/%name is
    needed)

(In reply to comment #5)
Hope correct all of above.

Spec URL: 
http://downloads.sourceforge.net/anyremote/ganyremote.spec
SRPM URL:
http://downloads.sourceforge.net/anyremote/ganyremote-2.8-1.fc8.src.rpm

For 2.8-1:

* spec file name
  - Again the name of the spec file must be "ganyremote.spec".
  - Also change the permission of tarball in srpm to 0644.

* %doc
  - Files under %_defaultdocdir are automatically regarded
    as %doc.

Please fix above. After that I guess I can approve this
package.

(In reply to comment #7)
Hope i corrected all the issues.

Spec URL: 
http://downloads.sourceforge.net/anyremote/ganyremote.spec
SRPM URL:
http://downloads.sourceforge.net/anyremote/ganyremote-2.8-2.fc8.src.rpm

[tasaka1@localhost ganyremote]$ md5sum */*gz
614f3d8ab4858e47839182dd49fc6290  ganyremote-2.8-1.fc8/ganyremote-2.8.tar.gz
d25ab9d85db6e6ae2f2dd6062783bf8f  ganyremote-2.8-2.fc8/ganyremote-2.8.tar.gz

Would you explain what happened?

Note:
- You seem to be the upstream of ganyremote. If so, please don't modify
  the released tarball without changing the version.
  This makes a confusion on people who will compile/installl ganyremote
  by themselves.

(In reply to comment #9)
> Would you explain what happened?
ganyremote.spec is a part of *.tar.gz. So, if i change spec file,
then *tar.gz in *src.rpm is changed. I believe nothing more was changed.

Well, okay.

------------------------------------------------------------------------
     This package (ganyremote) is APPROVED by me
------------------------------------------------------------------------

New Package CVS Request
=======================
Package Name: ganyremote
Short Description: gAnyRemote package is GTK GUI frontend for anyRemote
Owners: anyremote
Branches: F-8, F-9
InitialCC: anyremote
Cvsextras Commits: yes

I think the description here should be just: 

"GTK GUI frontend for anyRemote". I added it into the package database that way. 
Let me know if you disagree or would like it changed any. 

cvs done. 

I tried to run build ...
but something goes wrong (seems i made "make tag" several times)
Now i got:
----------------------------------------------
make tag
cvs tag  -c ganyremote-2_8-2_fc10
ERROR: Tag ganyremote-2_8-2_fc10 has been already created.
The following tags have been created so far
ganyremote-2_8-1_fc10:devel:anyremote:1209152554
ganyremote-2_8-1_fc9:F-9:anyremote:1209153297
ganyremote-2_8-2_fc9:F-9:anyremote:1209153884
ganyremote-2_8-2_fc10:devel:anyremote:1209154025
ganyremote-2_8-2_fc10:devel:anyremote:1209155226
cvs tag: Pre-tag check failed
cvs [tag aborted]: correct the above errors first!
make: *** [tag] Error 1
--------------------------------------------------

How to clean-up all the tags ?

But anyway "make build" works OK

If you want to re-tag, just bump release number.
If build is okay,
- For F-8 visit https://admin.fedoraproject.org/updates/
  and request to push your package to repository
- For F-9 visit https://admin.fedoraproject.org/updates/
  _later_. We cannot request to push  packages for now.

and close this bug as NEXTRELEASE.

So, should i close it now or after pushing to F-9 ?

You can close this bug now.