Bug 433234
| Summary: | Review Request: demorse - Command line tool for decoding Morse code signals | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert 'Bob' Jensen <bob> |
| Component: | Package Review | Assignee: | Jeroen van Meeuwen <vanmeeuwen+fedora> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | vanmeeuwen+fedora:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-02-20 03:39:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Robert 'Bob' Jensen
2008-02-17 22:22:53 UTC
md5sum between upstream source tarball and included tarball in SRPM do not match - did not yet run any other tests d96d63ba6f43b9d22ae8e910d4544d95 demorse-0.8.tar.gz RPM Lint: Package name: OK Spec file: OK License: OK Actual License: OK (from source code) %doc License: OK (missing COPYING or License file, upstream queried) Spec file language: OK Spec file readable: OK Upstream source vs. used tarball: OK (md5sums match) Compile and Build: - F-7: OK - F-8: OK - rawhide: OK - EL-5: OK Applicable Package Guidelines: - -debuginfo package: too small (~4.7K) Locales: N/A Shared libs: N/A Relocatable: N/A Directory and file ownership: OK No duplicate files in %files: OK File Permissions: OK Macro usage: OK Code vs. Content: OK (Large) Documentation: N/A, OK %doc affecting runtime: OK Header files in -devel package: N/A Static Libraries in -static package: N/A pkgconfig Requires: N/A Library files: N/A Devel requires base package: N/A .la libtool archives: N/A Duplicate ownership of files/directories: OK Remove BuildRoot: OK UTF-8 filenames: OK Please remove the -debuginfo package by patching the upstreams Makefile, removing --strip on line ~17. RPMLint is also OK btw ;-) the --strip is removed in the Makefile patch already, not sure what else to do. I cannot find where it gets -debuginfo from, if I run /usr/lib/rpm/find-debuginfo.sh manually it returns a couple of empty lists. So, not going to let this hold back the package: APPROVED New Package CVS Request ======================= Package Name: demorse Short Description: Command line tool for decoding Morse code signals Owners: bjensen,sconklin Branches: F-7 F-8 InitialCC: sindrepb Cvsextras Commits: Yes The debuginfo looks fine to me. It's so small because the executable in the main package is also very very small. It seems to be there and looks good though. cvs done. demorse-0.8-3.fc8 has been submitted as an update for Fedora 8 demorse-0.8-3.fc7 has been submitted as an update for Fedora 7 demorse-0.8-3.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. demorse-0.8-3.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |