Bug 433477
Summary: | Review Request: guake - Drop-down terminal for GNOME | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Torsten Trautwein <torstentrautwein> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | dpierce, fedora-package-review, guidolinfrancesco, mtasaka, notting |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-04-29 15:06:00 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 201449 |
Description
Torsten Trautwein
2008-02-19 15:45:35 UTC
Hi, this is an unofficial review. There are some things that need to be fixed: [-] You should use %{dist} in the release tag: Release: 1%{dist} [-] You should use %{?_smp_mflags} in the make command: make %{?_smp_mflags} this enable parallel build on multicore CPU. [-] Use %{_sysconfdir} instead of /etc: %{_sysconfdir}/gconf/schemas/guake.schemas Guidolin, thanks for your review. As this is my first rpm package, I really appreciate any feedback. I fixed the the mistakes you mentioned. The new version is available here: http://www.neowork.de/guake/guake.spec http://www.neowork.de/guake/guake-0.1-1.fc8.src.rpm http://www.neowork.de/guake/guake-0.1-1.fc8.i386.rpm http://www.neowork.de/guake/guake-debuginfo-0.1-1.fc8.i386.rpm Thanks, Torsten Ok, there are some other things: [-] The recommended value for the BuildRoot tag is: BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 [-] Packages should not use the PreReq tag. http://fedoraproject.org/wiki/Packaging/Guidelines#head-c81b037a3a0d08f98eb9cb50594f5de73d1e461d [-] *.la file should be removed. Add: find %{buildroot} -name \*\.la -delete after make install and remove those file from the file list. http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7 ping? ping again? This review request will be closed if no response from the reporter is received within ONE WEEK. Once closing. If someone wants to import this package into Fedora, please file a new review request and mark this bug a duplicate of the new one. Thank you! |