Bug 433488
| Summary: | Review Request: dayplanner - An easy and clean Day Planner | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Krzysztof Kurzawski <kurzawax> | ||||||||
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> | ||||||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | rawhide | CC: | fedora-package-review, johnny.d, mtasaka, notting | ||||||||
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2008-03-06 14:46:58 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Krzysztof Kurzawski
2008-02-19 16:32:15 UTC
Could someone review this please? *** Bug 222964 has been marked as a duplicate of this bug. *** Created attachment 296520 [details]
Current holidays in Japan
For quick glance:
- Please avoid to use %makeinstall if possible.
- Japanese current holidays are attached.
- The line "chmod a-x ...." must be dealt with more preferable way.
* One can easy imagine that the installed files list changes in the
next version.
----------------------------------------------------------------
find $RPM_BUILD_ROOT%{_datadir}/%{name} -name \*.pm -exec chmod 0644 {} \;
----------------------------------------------------------------
can replace the current line, I guess.
Created attachment 296522 [details]
Current holidays in Japan (spell fixed)
NAOJ = National Astronomy Observatory of Japan...
Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/dayplanner/dayplanner.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/dayplanner/dayplanner-0.8.1-2.fc8.src.rpm : Last modified: May 3, 2008 : by Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> Is date correct? Thanks for review! P.S If you have time could you also review this: https://bugzilla.redhat.com/show_bug.cgi?id=434614? Thanks in advance! Created attachment 296726 [details] holiday_japan again. > : Last modified: May 3, 2008 > : by Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> > Is date correct? Of course not correct... Well, * Replace /usr with %{_prefix} (prefix=/usr) * For perl modules dependency, don't write rpm names directly but write the module names the rpms provide, such as "BuildRequires: perl(Locale::gettext)" ! By the way, devel-tools/GenDesktop needs perl(Locale:gettext), but this script doesn't seem to be called and actually your srpm builds without BuildRequires: perl-gettext: http://koji.fedoraproject.org/koji/taskinfo?taskID=490198 Other things are okay. ---------------------------------------------------------------- This package (dayplanner) is APPROVED by me ---------------------------------------------------------------- P.S. > P.S If you have time could you also review this: > https://bugzilla.redhat.com/show_bug.cgi?id=434614? Thanks in advance! Well, for the last few days I was checking review requests to which I had not replied for a few days and actually it seems I have commented on about 20 review requests within these 5 days... So if you want me to review the above, would you wait a bit, please? Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/dayplanner/dayplanner.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/dayplanner/dayplanner-0.8.1-3.fc8.src.rpm P.S Ok, I'm waiting for review. New Package CVS Request ======================= Package Name: dayplanner Short Description: An easy and clean Day Planner Owners: kurzawa Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes cvs done. Imported and built. Thanks again for review! |